Added cookbook to increment versions across all plugins. #119

dblock · 2021-12-17T23:34:37Z

Description

This is what I had to do to make a 1.2.3 build.

Issues Resolved

Coming from opensearch-project/opensearch-build#1365.

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peternied

Thanks for writing this all up

dblock · 2021-12-18T16:11:20Z

This is now complete given that opensearch-project/opensearch-build#1380 passed all tests. Ready for CR/merge @peternied @saratvemulapalli.

dblock · 2021-12-18T17:37:59Z

@saratvemulapalli @peternied @peterzhuamazon Do you know/think release notes is also something one person can do across all plugins? If so, can you please help me with a cookbook on top of this?

davidlago · 2021-12-20T15:33:02Z

@dblock for release notes, this is what we do in the security plugin (using 1.2.3 as an example to make the step-by-step explanation easier):

Get a diff from 1.2 branch's HEAD and tag 1.2.2.0
Figure out the list of PRs that were merged in that window
Classify them between features, bug fixes and maintenance (sometimes this can be inferred from the related issue's tags, but this is mostly a manual step for now. If we were to automate this, we would have to be able to fully trust 1) all PRs have an associated issue and 2) all issues have (among others) a tag that helps with this classification. This is not true today.
Create a new release notes file (this could be easily "templatized") with a list of changes grouped by category
PR out to main with the release notes file. This will be cherry-picked into 1.2 before creating the 1.2.3.0 tag

Signed-off-by: dblock <dblock@amazon.com>

Signed-off-by: dblock <dblock@dblock.org>

META.md

…rch is true for any version. Signed-off-by: dblock <dblock@amazon.com>

davidlago · 2021-12-23T15:05:40Z

META.md

+```
+find . -name build.gradle -print0 | xargs -0 sed -i "s/1.2.2/1.2.3/g"
+find . -name CMakeLists.txt -print0 | xargs -0 sed -i "s/1.2.2.0/1.2.3.0/g"
+find . -name pom.xml -print0 | xargs -0 sed -i "s/1.2.2/1.2.3/g"


Beware of blanket find/replace statements. In security, for example, bumping from 1.2.3 to 1.2.4 would have also matched this https://github.com/opensearch-project/security/blob/main/pom.xml#L81

Fair enough! I think it’s a poor man’s implementation anyway. What we really need is GHA workflows in each repo that increment versions based on created tags.

Here are two attempts at that:

opensearch-project/OpenSearch#1816
opensearch-project/common-utils#106

+1 to the component specific actions. It makes it easier for component owners.

dblock · 2022-01-03T23:06:19Z

@saratvemulapalli @peternied Can I please get a CR on this?

saratvemulapalli

Thanks @dblock this is really helpful.
Dropped a minor comment.

saratvemulapalli · 2022-01-04T17:06:35Z

META.md

+```
+find . -name build.gradle -print0 | xargs -0 sed -i "s/1.2.2/1.2.3/g"
+find . -name CMakeLists.txt -print0 | xargs -0 sed -i "s/1.2.2.0/1.2.3.0/g"
+find . -name pom.xml -print0 | xargs -0 sed -i "s/1.2.2/1.2.3/g"


+1 to the component specific actions. It makes it easier for component owners.

saratvemulapalli · 2022-01-04T17:12:11Z

META.md

+```
+meta git update
+meta git pull origin
+meta git checkout 1.2


Not a blocker for this PR, just a thought.
I think having an ENV variable for these versions might make it easier when we run this for future versions.

This is a good idea, did it anyway.

Signed-off-by: dblock <dblock@amazon.com>

dblock · 2022-01-05T13:42:50Z

@saratvemulapalli @peternied Re-check please?

Signed-off-by: dblock <dblock@amazon.com>

dblock force-pushed the increment-versions branch from eeb3341 to d1e1c45 Compare December 17, 2021 23:53

dblock marked this pull request as ready for review December 17, 2021 23:53

dblock requested review from a team, peternied and saratvemulapalli December 17, 2021 23:53

peternied previously approved these changes Dec 18, 2021

View reviewed changes

dblock dismissed peternied’s stale review via a3d945f December 18, 2021 00:15

dblock force-pushed the increment-versions branch from d1e1c45 to a3d945f Compare December 18, 2021 00:15

dblock requested a review from peternied December 18, 2021 00:16

This was referenced Dec 18, 2021

Replace maven by gradle opensearch-project/security#1533

Closed

OpenSearch: Automate increment to next development iteration opensearch-project/opensearch-build#1375

Closed

dblock force-pushed the increment-versions branch from a3d945f to ac3e209 Compare December 18, 2021 00:47

dblock requested a review from CEHENKLE December 18, 2021 16:11

dblock mentioned this pull request Dec 20, 2021

[FEATURE] Automate and standardize generation of release notes #120

Open

dblock added 4 commits December 21, 2021 12:33

Added cookbook to increment versions across all plugins.

8d14c85

Signed-off-by: dblock <dblock@amazon.com>

Added cross-cluster-replication SecurityAdminWrapper info.

534ab2d

Signed-off-by: dblock <dblock@amazon.com>

Added performance-analyzer-rca.

f7e6684

Signed-off-by: dblock <dblock@amazon.com>

Drop some zeros.

162f8e2

Signed-off-by: dblock <dblock@amazon.com>

dblock force-pushed the increment-versions branch 2 times, most recently from 6ab6f09 to 162f8e2 Compare December 21, 2021 12:42

dblock added 2 commits December 21, 2021 12:43

Restored old meta formatting.

2a3a594

Signed-off-by: dblock <dblock@dblock.org>

Removed unused file.

6a00842

Signed-off-by: dblock <dblock@dblock.org>

dblock requested review from bbarani and peterzhuamazon December 22, 2021 17:58

bbarani reviewed Dec 22, 2021

View reviewed changes

META.md Outdated Show resolved Hide resolved

bbarani previously approved these changes Dec 22, 2021

View reviewed changes

Remove patch, not being able to install on a newer version of OpenSea…

efc5103

…rch is true for any version. Signed-off-by: dblock <dblock@amazon.com>

dblock dismissed bbarani’s stale review via efc5103 December 22, 2021 19:09

dblock requested a review from bbarani December 22, 2021 19:09

davidlago reviewed Dec 23, 2021

View reviewed changes

saratvemulapalli previously approved these changes Jan 4, 2022

View reviewed changes

davidlago mentioned this pull request Jan 5, 2022

Incremented version to 1.2.4. opensearch-project/security#1550

Closed

dblock added 2 commits January 5, 2022 08:30

Swap order.

2722486

Signed-off-by: dblock <dblock@amazon.com>

Use environment variables.

b8b0a6b

Signed-off-by: dblock <dblock@amazon.com>

dblock dismissed saratvemulapalli’s stale review via b8b0a6b January 5, 2022 13:42

dblock requested a review from saratvemulapalli January 5, 2022 13:42

Added performance-analyzer-rca to .gitignore.

eac213b

Signed-off-by: dblock <dblock@amazon.com>

saratvemulapalli approved these changes Jan 5, 2022

View reviewed changes

peternied approved these changes Jan 5, 2022

View reviewed changes

dblock merged commit f4fb593 into opensearch-project:main Jan 5, 2022

dblock deleted the increment-versions branch January 5, 2022 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added cookbook to increment versions across all plugins. #119

Added cookbook to increment versions across all plugins. #119

dblock commented Dec 17, 2021

peternied left a comment

dblock commented Dec 18, 2021

dblock commented Dec 18, 2021 •

edited

Loading

davidlago commented Dec 20, 2021 •

edited

Loading

davidlago Dec 23, 2021 •

edited

Loading

dblock Dec 23, 2021

dblock Dec 28, 2021

saratvemulapalli Jan 4, 2022

dblock commented Jan 3, 2022

saratvemulapalli left a comment

saratvemulapalli Jan 4, 2022

saratvemulapalli Jan 4, 2022

dblock Jan 5, 2022

dblock commented Jan 5, 2022

Added cookbook to increment versions across all plugins. #119

Added cookbook to increment versions across all plugins. #119

Conversation

dblock commented Dec 17, 2021

Description

Issues Resolved

Check List

peternied left a comment

Choose a reason for hiding this comment

dblock commented Dec 18, 2021

dblock commented Dec 18, 2021 • edited Loading

davidlago commented Dec 20, 2021 • edited Loading

davidlago Dec 23, 2021 • edited Loading

Choose a reason for hiding this comment

dblock Dec 23, 2021

Choose a reason for hiding this comment

dblock Dec 28, 2021

Choose a reason for hiding this comment

saratvemulapalli Jan 4, 2022

Choose a reason for hiding this comment

dblock commented Jan 3, 2022

saratvemulapalli left a comment

Choose a reason for hiding this comment

saratvemulapalli Jan 4, 2022

Choose a reason for hiding this comment

saratvemulapalli Jan 4, 2022

Choose a reason for hiding this comment

dblock Jan 5, 2022

Choose a reason for hiding this comment

dblock commented Jan 5, 2022

dblock commented Dec 18, 2021 •

edited

Loading

davidlago commented Dec 20, 2021 •

edited

Loading

davidlago Dec 23, 2021 •

edited

Loading