-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct demo_ml_commons_integration.ipynb #208
Merged
dhrubo-os
merged 2 commits into
opensearch-project:main
from
thanawan-atc:fix_integration_notebook
Aug 9, 2023
Merged
Correct demo_ml_commons_integration.ipynb #208
dhrubo-os
merged 2 commits into
opensearch-project:main
from
thanawan-atc:fix_integration_notebook
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
thanawan-atc
requested review from
dhrubo-os,
greaa-aws,
ylwu-amzn,
b4sjoo,
jngz-es and
rbhavna
as code owners
August 9, 2023 20:12
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 91.25% 91.26%
=======================================
Files 37 37
Lines 4130 4131 +1
=======================================
+ Hits 3769 3770 +1
Misses 361 361
|
dhrubo-os
approved these changes
Aug 9, 2023
rbhavna
approved these changes
Aug 9, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-208-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd50b8bc82120a3b0f7e6c2e6d1e6c89695125b9
# Push it to GitHub
git push --set-upstream origin backport/backport-208-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
* Correct demo_ml_commons_integration.ipynb Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
* Correct demo_ml_commons_integration.ipynb Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
* Correct demo_ml_commons_integration.ipynb Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit 212bac6.
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit 664e447.
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit c67f969.
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit 664e447.
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit c67f969.
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit 212bac6.
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit 664e447. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit c67f969. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 10, 2023
This reverts commit 212bac6. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
* Correct demo_ml_commons_integration.ipynb Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit bd50b8b)
dhrubo-os
pushed a commit
that referenced
this pull request
Aug 10, 2023
* Correct demo_ml_commons_integration.ipynb Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit bd50b8b) Co-authored-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
thanawan-atc
referenced
this pull request
in thanawan-atc/opensearch-py-ml
Aug 11, 2023
This reverts commit 212bac6. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
3 tasks
dhrubo-os
pushed a commit
that referenced
this pull request
Aug 19, 2023
…loading (#209) * Initiate PR #1 Model Auto-tracing & Uploading Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve update_changelog_md.py & sentencetransformermodel.py scraping Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change default to N/A Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_models_upload_history_md.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update delete_model_uploader_branch.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting & Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Revert "Correct demo_ml_commons_integration.ipynb (#208)" This reverts commit 664e447. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Small fix Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add model_type Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2023
…loading (#209) * Initiate PR #1 Model Auto-tracing & Uploading Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve update_changelog_md.py & sentencetransformermodel.py scraping Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change default to N/A Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_models_upload_history_md.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update delete_model_uploader_branch.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting & Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Revert "Correct demo_ml_commons_integration.ipynb (#208)" This reverts commit 664e447. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Small fix Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add model_type Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 20223e6)
dhrubo-os
pushed a commit
that referenced
this pull request
Aug 21, 2023
* [Automating Model Tracing and Uploading] PR 1 Model Auto-tracing & Uploading (#209) * Initiate PR #1 Model Auto-tracing & Uploading Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve update_changelog_md.py & sentencetransformermodel.py scraping Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change default to N/A Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_models_upload_history_md.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update delete_model_uploader_branch.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting & Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Revert "Correct demo_ml_commons_integration.ipynb (#208)" This reverts commit 664e447. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Small fix Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add model_type Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update model_autotracing.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 20223e6) * Correct test_sentencetransformermodel_pytest.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix tests/ml_models/test_sentencetransformermodel_pytest.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
dhrubo-os
pushed a commit
that referenced
this pull request
Aug 22, 2023
#210) * Initiate PR #2 Model Listing & Uploading Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add comment Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Revert "Correct demo_ml_commons_integration.ipynb (#208)" This reverts commit c67f969. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add steps.checkout_pr_branch.outcome Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove old config json Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Minor change Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Allow non-st Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add tests for PR2 Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Create __init__.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Create __init__.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update setup.cfg Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add more test to improve coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve test cov Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Make it extensible Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Avoid crashing if folder does not exists Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Wrap with update_pretrained_model_listing_main Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove unused variables Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove unnecessary variable Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
#210) * Initiate PR #2 Model Listing & Uploading Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add comment Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Revert "Correct demo_ml_commons_integration.ipynb (#208)" This reverts commit c67f969. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add steps.checkout_pr_branch.outcome Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove old config json Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Minor change Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Allow non-st Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add tests for PR2 Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Create __init__.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Create __init__.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update setup.cfg Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add more test to improve coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve test cov Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Make it extensible Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Avoid crashing if folder does not exists Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Wrap with update_pretrained_model_listing_main Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove unused variables Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove unnecessary variable Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 205a0fd)
dhrubo-os
pushed a commit
that referenced
this pull request
Aug 22, 2023
… Jenkins (#211) * Initiate PR #3 Jenkins Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add option back Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Minor change Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Revert "Correct demo_ml_commons_integration.ipynb (#208)" This reverts commit 212bac6. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update utils/model_uploader/trigger_ml_models_release.sh Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Thanawan Atchariyachanvanit <thanawan.atc@gmail.com> Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update utils/model_uploader/trigger_ml_models_release.sh Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Thanawan Atchariyachanvanit <thanawan.atc@gmail.com> Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update utils/model_uploader/trigger_ml_models_release.sh Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Thanawan Atchariyachanvanit <thanawan.atc@gmail.com> Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update ml-models.JenkinsFile Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add comment to JenkinsFile Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> Signed-off-by: Thanawan Atchariyachanvanit <thanawan.atc@gmail.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
dhrubo-os
pushed a commit
that referenced
this pull request
Aug 22, 2023
#210) (#238) * Initiate PR #2 Model Listing & Uploading Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add comment Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Revert "Correct demo_ml_commons_integration.ipynb (#208)" This reverts commit c67f969. Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Removed a modified file from pull request Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add steps.checkout_pr_branch.outcome Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove old config json Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Minor change Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Allow non-st Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add tests for PR2 Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Create __init__.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Create __init__.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update setup.cfg Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update noxfile.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add more test to improve coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve test cov Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Make it extensible Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Avoid crashing if folder does not exists Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Wrap with update_pretrained_model_listing_main Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update update_model_listing.yml Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove unused variables Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove unnecessary variable Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 205a0fd) Co-authored-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct demo_ml_commons_integration.ipynb so that the output matches description
Issues Resolved
#207
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.