Backport #203 to 1.x #216
Merged
Backport #203 to 1.x #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating notebook + bumping version Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 1237aa6)
* Add description field Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Restore notebook Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Resolve linting issues Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test_sentencetransformermodel_pytest.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve test coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Edit test name Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change CHANGELOG.md & Add comment to sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve add description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Loosen restriction Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change function name + Add comment + Add default description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 20435b1)
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
dhrubo-os
approved these changes
Aug 10, 2023
Codecov Report
@@ Coverage Diff @@
## 1.x #216 +/- ##
==========================================
+ Coverage 91.15% 91.23% +0.08%
==========================================
Files 37 37
Lines 4092 4130 +38
==========================================
+ Hits 3730 3768 +38
Misses 362 362
|
rbhavna
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport PR #203
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.