Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create external connector and local connector #325

Closed
wants to merge 6 commits into from

Conversation

Vinay-Vinod
Copy link
Contributor

@Vinay-Vinod Vinay-Vinod commented Oct 25, 2023

Description

Adds support for external connector and local connector. Supports endpoints for:
connection.ml_connector.create()
connection.ml_connector.delete()
connection.ml_connector.list()
connection.ml_connector.search()

Issues Resolved

[List any issues this PR will resolve]
Solves [FEATURE] Support for ML Extensibility #284

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dtaivpp
Copy link
Contributor

dtaivpp commented Oct 26, 2023

Ooh! I'll try and test this asap! Thank you 😄

Signed-off-by: Vinay Vinod <briarvinay@gmail.com>
@dhrubo-os
Copy link
Collaborator

Can we please add corresponding tests also? Please check other functions.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #325 (4a14ec5) into main (4a8a3e7) will decrease coverage by 0.17%.
Report is 1 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   91.36%   91.19%   -0.17%     
==========================================
  Files          38       38              
  Lines        4237     4249      +12     
==========================================
+ Hits         3871     3875       +4     
- Misses        366      374       +8     
Files Coverage Δ
opensearch_py_ml/ml_commons/ml_commons_client.py 81.14% <33.33%> (-3.52%) ⬇️

@dhrubo-os
Copy link
Collaborator

lint is failing. Could you please check. You should be able to run nox -s lint in your end to fix this.

@dhrubo-os
Copy link
Collaborator

@Vinay-Vinod are you working on this issue?

@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Nov 13, 2023

Are you having any issues with git? Please feel free to ask question in the slack channel if you are blocked. In addition, we need this PR to be done asap. Could you please give any ETA? Thanks.

@Vinay-Vinod
Copy link
Contributor Author

Was having issue running the linter, but was able to fix

@dhrubo-os
Copy link
Collaborator

Merge conflict.

@dhrubo-os
Copy link
Collaborator

Any ETA to wrap up this PR? Turns out we need this support in py-ml asap. Let me know if you are available to expedite this development. Otherwise, I will try to assign this someone else. Thanks.

@Vinay-Vinod
Copy link
Contributor Author

I dont know why I keep failing some of the linting tests, but I'm pretty sure my code is right. You can assign the issue to someone else since this is needed ASAP @dhrubo-os

@dhrubo-os
Copy link
Collaborator

@rawwar could you please take over this PR then?

@dhrubo-os
Copy link
Collaborator

@Vinay-Vinod can we close this PR in respect of this PR?

@Vinay-Vinod
Copy link
Contributor Author

Yes of course, go ahead @dhrubo-os

@Vinay-Vinod Vinay-Vinod closed this Dec 6, 2023
@Vinay-Vinod
Copy link
Contributor Author

Closelose this PR in respect of PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants