Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reordering ml_commons tests : moved test_search to the end #330

Merged

Conversation

rawwar
Copy link
Contributor

@rawwar rawwar commented Nov 2, 2023

Raised another PR as I was unable to sign off a commit in the previous PR.

Fixes #326

Having test_search at the start of the module is making it to run first. Since pytest runs tests by the order they appear in the module. Moving test_search to the end should help to mitigate this issue

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: kalyan <kalyan.ben10@live.com>
Signed-off-by: kalyan <kalyan.ben10@live.com>
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #330 (59d3693) into main (5ca5aa8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          38       38           
  Lines        4230     4230           
=======================================
  Hits         3864     3864           
  Misses        366      366           

@rawwar
Copy link
Contributor Author

rawwar commented Nov 2, 2023

@dhrubo-os , raised another PR with sign off on all commits.

@dhrubo-os dhrubo-os merged commit da415f0 into opensearch-project:main Nov 2, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] test_search fails when there are no tasks
3 participants