Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#339 : Remove separate pandas installations in nox tests #368

Merged

Conversation

rawwar
Copy link
Contributor

@rawwar rawwar commented Jan 6, 2024

Description

Remove separate pandas installations in nox tests

Issues Resolved

fixes #339

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (261eab5) 91.53% compared to head (d1912bf) 91.53%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          42       42           
  Lines        4395     4395           
=======================================
  Hits         4023     4023           
  Misses        372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rawwar rawwar marked this pull request as ready for review January 6, 2024 07:55
@rawwar
Copy link
Contributor Author

rawwar commented Jan 6, 2024

@dhrubo-os , this closes #339 .

@Yerzhaisang , consider going through the changes. Once this is merged, you can go ahead with the upgrading pandas version issue.

@Yerzhaisang
Copy link
Contributor

cool @rawwar

…ch-py-ml into kalyan/339-remove-pandas-versions-nox

Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@dhrubo-os dhrubo-os merged commit e0b1bcf into opensearch-project:main Feb 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Remove pin on the pandas version in nox tests
4 participants