Refactored code base #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
build.gradle
Outdated
| @@ -25,7 +25,7 @@ ext { | |||
| apply plugin: 'application' | |||
| apply from: 'gradle/formatting.gradle' | |||
|
|
|||
| mainClassName = 'transportservice.ExtensionsRunner' | |||
| mainClassName = 'opensearchSDK.transport.ExtensionsRunner' | |||
There was a problem hiding this comment.
Can we pull out the runner from Transport?
Conceptually Runner has nothing to do with Transport, it just initializes a bunch of data structures needed for an extension to run.
| @@ -30,7 +30,7 @@ | |||
| * GitHub history for details. | |||
| */ | |||
|
|
|||
| package transportservice.netty4; | |||
| package opensearchSDK.netty4; | |||
There was a problem hiding this comment.
Let this be opensearchSDK.transport.xyz ?
This is a direct package from https://github.com/opensearch-project/OpenSearch/blob/main/modules/transport-netty4/src/main/java/org/opensearch/transport/netty4/Netty4MessageChannelHandler.java#L33
Lets keep it consistent and whenever we close opensearch-project/OpenSearch#3118
We can remove this piece of code easily.
joshpalis
approved these changes
May 6, 2022
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
force-pushed
the
update-package-name
branch
from
97c8bcc
to
fe5577b
Compare
ryanbogan
approved these changes
May 6, 2022
saratvemulapalli
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Owais Kazi owaiskazi19@gmail.com
Description
Restructured the code base
Issues Resolved
Closes #5
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.