Add handlers for read, update, and delete to CREATE_YOUR_FIRST_EXTENSION doc #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
owaiskazi19
reviewed
Jul 9, 2023
owaiskazi19
previously approved these changes
Jul 9, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
previously approved these changes
Jul 9, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
joshpalis
previously approved these changes
Jul 10, 2023
owaiskazi19
reviewed
Jul 10, 2023
kolchfa-aws
reviewed
Jul 10, 2023
natebower
reviewed
Jul 10, 2023
There was a problem hiding this comment.
A few more comments, some similar to @kolchfa-aws but with an addition or two. Thanks!
Thanks! Can you tell I spent way too long in academia where "we" is the standard? :) |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
|
Yes, "we" when we're doing an experiment, and "you" when you want the user to do something :) |
dbwiddis
requested review from
joshpalis,
owaiskazi19,
natebower and
kolchfa-aws
owaiskazi19
approved these changes
Jul 11, 2023
joshpalis
approved these changes
Jul 11, 2023
|
@kolchfa-aws @natebower looks good to you before we merge the changes in? |
|
LGTM 😄 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…ION doc (#864) * Add handlers for read, update, and delete Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove reference to SDKClient Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add link to TOC Signed-off-by: Daniel Widdis <widdis@gmail.com> * Replace we with you and only use one space after a full stop Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit 67046b2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jul 12, 2023
…ION doc (#864) (#878) * Add handlers for read, update, and delete * Remove reference to SDKClient * Add link to TOC * Replace we with you and only use one space after a full stop --------- (cherry picked from commit 67046b2) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
DarshitChanpura
pushed a commit
to DarshitChanpura/opensearch-sdk-java
that referenced
this pull request
Jul 12, 2023
…ION doc (opensearch-project#864) (opensearch-project#878) * Add handlers for read, update, and delete * Remove reference to SDKClient * Add link to TOC * Replace we with you and only use one space after a full stop --------- (cherry picked from commit 67046b2) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
DarshitChanpura
pushed a commit
to DarshitChanpura/opensearch-sdk-java
that referenced
this pull request
Jul 12, 2023
…ION doc (opensearch-project#864) (opensearch-project#878) * Add handlers for read, update, and delete * Remove reference to SDKClient * Add link to TOC * Replace we with you and only use one space after a full stop --------- (cherry picked from commit 67046b2) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
CREATE_YOUR_FIRST_EXTENSIONwith the RUD part of CRUD (and a better C example). Also fixes the internal links broken in earlier reviews.Please merge #827 (and then rebase this PR) prior to merging this PR, as this builds on updates from that PR to Named Routes.
Reference project implementing this, with the code tested: https://github.com/dbwiddis/CRUDExtension
Issues Resolved
Part of #836 (Documentation)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.