Adding CI matrix for jdk 8, 11 and 14 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgup432
force-pushed
the
ci_matrix_changes
branch
from
21d6f60
to
bc880a9
Compare
sruti1312
previously approved these changes
Mar 11, 2022
Merged
5 tasks
kkhatua
previously approved these changes
Mar 12, 2022
sruti1312
previously approved these changes
Mar 12, 2022
Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com>
sgup432
force-pushed
the
ci_matrix_changes
branch
from
5383c23
to
60eb300
Compare
sruti1312
previously approved these changes
Mar 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
============================================
+ Coverage 72.03% 72.29% +0.26%
- Complexity 355 356 +1
============================================
Files 44 44
Lines 2510 2516 +6
Branches 160 168 +8
============================================
+ Hits 1808 1819 +11
+ Misses 595 591 -4
+ Partials 107 106 -1
Continue to review full report at Codecov.
|
dzane17
previously approved these changes
Mar 12, 2022
Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com>
Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com>
sruti1312
approved these changes
Mar 14, 2022
kkhatua
approved these changes
Mar 15, 2022
sruti1312
pushed a commit
that referenced
this pull request
Mar 15, 2022
* Adding CI matrix for jdk 8, 11 and 14 Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> * Removing exclude tools.jar logic Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> * Excluding rolling upgrade test for jdk8 Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> Co-authored-by: Sagar Upadhyaya <upasagar@amazon.com>
sruti1312
pushed a commit
that referenced
this pull request
Mar 15, 2022
* Adding CI matrix for jdk 8, 11 and 14 Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> * Removing exclude tools.jar logic Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> * Excluding rolling upgrade test for jdk8 Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> Co-authored-by: Sagar Upadhyaya <upasagar@amazon.com> Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312
added a commit
that referenced
this pull request
Mar 15, 2022
* Adding 1.3 release notes (#161) * Adding 1.3 release notes Signed-off-by: David Zane <davizane@amazon.com> * Add PA-RCA commits to release notes Signed-off-by: David Zane <davizane@amazon.com> * Remove @ symbol to pass link checker Signed-off-by: David Zane <davizane@amazon.com> * Adding check to avoid adding module export for jdk8 (#162) Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> Co-authored-by: Sagar Upadhyaya <upasagar@amazon.com> * Updates integTest gradle scripts to run via remote cluster independently (#160) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Disabling dependency license check for now in gradle to unblock jdk8 build (#163) Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> Co-authored-by: Sagar Upadhyaya <upasagar@amazon.com> * Adding CI matrix for jdk 8, 11 and 14 (#159) * Adding CI matrix for jdk 8, 11 and 14 Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> * Removing exclude tools.jar logic Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> * Excluding rolling upgrade test for jdk8 Signed-off-by: Sagar Upadhyaya <upasagar@amazon.com> Co-authored-by: Sagar Upadhyaya <upasagar@amazon.com> Signed-off-by: sruti1312 <srutiparthiban@gmail.com> Co-authored-by: David Z <38449481+dzane17@users.noreply.github.com> Co-authored-by: Sagar <99425694+sgup432@users.noreply.github.com> Co-authored-by: Sagar Upadhyaya <upasagar@amazon.com>
dblock
reviewed
Mar 15, 2022
| @@ -644,7 +643,10 @@ task bwcTestSuite(type: StandaloneRestIntegTestTask) { | |||
| exclude '**/*Test*' | |||
| exclude '**/*IT*' | |||
| dependsOn tasks.named("${baseName}#mixedClusterTask") | |||
| dependsOn tasks.named("${baseName}#rollingUpgradeClusterTask") | |||
| if (JavaVersion.current() > JavaVersion.VERSION_1_8) { | |||
| // Only running this for > jdk8 versions as of now. | |||
There was a problem hiding this comment.
What's the issue number for this failure? I don't see one. The comment should have contained a link to that.
There was a problem hiding this comment.
I just created an issue for this - #170.
Would track this via above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Solves: #91
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.