Rename for OpenSearch #1126
Rename for OpenSearch #1126
Conversation
| @@ -68,7 +68,7 @@ | |||
| <maven.compiler.target>1.8</maven.compiler.target> | |||
| <maven.compiler.release>8</maven.compiler.release> | |||
|
|
|||
| <elasticsearch.version>7.10.2</elasticsearch.version> | |||
| <opensearch.version>7.10.3-SNAPSHOT</opensearch.version> | |||
There was a problem hiding this comment.
Using snapshot is only acceptable within the same project. When opensearch will publish artifacts to maven repo?
There was a problem hiding this comment.
There hasn't been a clear date yet.
There was a problem hiding this comment.
Publishing artifacts to Maven repo is not there yet, no ETA either.
We might publish SNAPSHOT versions until release candidate is out, again thats a TBD.
Its up to you guys how you'd like have it.
There was a problem hiding this comment.
@saratvemulapalli Merging that CR without artifacts being available will block any further development on security plugin side.
There was a problem hiding this comment.
Sure we are working on 2 paths:
- Short term: Checkout OpenSearch repo in your workflows and publish artifacts locally using
./gradlew publishToMavenLocal. This should get you the artifacts. Also note the artifacts will be OpenSearch 1.0.0 instead of 7.10.3, if you'd like 7.10.3 use 1.x branch. - Long term: Artifacts are going to be in maven central, we have no ETA and its TBD.
There was a problem hiding this comment.
I opened opensearch-project/OpenSearch#581 to track MavenCentral work for OpenSearch. If you want to work around that rn, check out opensearch-project/anomaly-detection#9
There was a problem hiding this comment.
Why not to use jitpack.io to publish opensearch snapshot artifacts instead of publishing to local maven repo that will require even more workarounds for CI/CD?
There was a problem hiding this comment.
Sure, we are looking for any solutions which work for everyone. We are not opposed to any solution.
Coming to jitpack.io I don't know how it works, if you can help us understand how it works or use it in the security plugin if that helps you guys, feel free to do that.
...ava/com/amazon/opendistroforelasticsearch/security/auditlog/sink/InternalOpenSearchSink.java
Show resolved
Hide resolved
src/main/java/com/amazon/dlic/auth/http/kerberos/HTTPSpnegoAuthenticator.java
Show resolved
Hide resolved
...main/java/com/amazon/opendistroforelasticsearch/security/auditlog/impl/AbstractAuditLog.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/security/compliance/ComplianceConfig.java
Outdated
Show resolved
Hide resolved
...in/java/com/amazon/opendistroforelasticsearch/security/dlic/rest/api/WhitelistApiAction.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,33 @@ | |||
| --- | |||
There was a problem hiding this comment.
Why do we need this as part of rename?
There was a problem hiding this comment.
Because this is a part of the renaming requirements.
There was a problem hiding this comment.
Can't it be part of a separate PR? It is hard to review PR that combines loosely related changes into one big PR.
There was a problem hiding this comment.
It can. But bug_template.md and feature_request.md are only 2 files newly added, if it's not too hard to review, can we go with a single PR given the matter of time?
* Rename for OpenSearch
* Rename for OpenSearch
opendistro-for-elasticsearch/security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Refactoring
Github Issue # or road-map entry, if available:
Description of changes:
Rename ElasticSearch to OpenSearch
Why these changes are required?
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
securityconfigfolder.TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
Is it backport from main branch? (If yes, please add backport PR # and commits #)
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.