Remove references to LegacyESVersion.V_7x constants #2151
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
| @@ -72,7 +72,7 @@ public TransportConfigUpdateAction(final Settings settings, | |||
| this.dynamicConfigFactory = dynamicConfigFactory; | |||
| } | |||
|
|
|||
| public static class NodeConfigUpdateRequest extends BaseNodeRequest { | |||
| public static class NodeConfigUpdateRequest extends TransportRequest { | |||
There was a problem hiding this comment.
What would this change achieve and does it break anything?
There was a problem hiding this comment.
This class was removed in 3.0.0. I followed the docstring
/**
* Base class for node transport requests
*
* @opensearch.internal
*
* @deprecated this class is deprecated and classes will extend TransportRequest directly
*/
// TODO: this class can be removed in main once 7.x is bumped to 7.4.0
@Deprecated
public abstract class BaseNodeRequest extends TransportRequest {
| @@ -100,11 +100,6 @@ protected void handlePost(RestChannel channel, RestRequest request, Client clien | |||
|
|
|||
| final Version oldestNodeVersion = cs.state().getNodes().getMinNodeVersion(); | |||
|
|
|||
| if(oldestNodeVersion.before(LegacyESVersion.V_7_0_0)) { | |||
There was a problem hiding this comment.
Instead of removing this, should we be replacing it with oldest that we currently support?
|
The build will fail until there's a new distribution build available for 3.0.0. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
| log.trace("has6xIndices: {}", has6xIndices); | ||
| } | ||
| } | ||
|
|
||
| if(nodes == null || event.nodesChanged()) { |
There was a problem hiding this comment.
We only need to track when nodes change now not also when indices are created & deleted?
There was a problem hiding this comment.
The purpose of this code is to log if there are 6.X nodes or indices in the cluster upon change (node was added/removed from the cluster or an index was created or deleted). If its not possible to run es 6.X nodes with os 3.X then this code will never be used.
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
After this is merged it will fix the build break on main and for the distrobution |
src/main/java/org/opensearch/security/configuration/ClusterInfoHolder.java
Show resolved
Hide resolved
…ct#2151) * Remove references to LegacyESVersion.V_7x constants Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Craig Perkins cwperx@amazon.com
Description
Removes all 7.x constants and logic that is no longer supported in 3.0.
See: opensearch-project/OpenSearch#2747
Related distribution build failure due to removal of these constants in core:
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.