Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add groupId = org.opensearch.plugin #2158

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

prudhvigodithi
Copy link
Contributor

Signed-off-by: prudhvigodithi pgodithi@amazon.com

Description

Added groupId as org.opensearch.plugin in pluginZip publication

Issues Resolved

#2055

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi prudhvigodithi requested a review from a team October 12, 2022 18:16
@prudhvigodithi prudhvigodithi added backport 2.x backport to 2.x branch v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 12, 2022
peternied
peternied previously approved these changes Oct 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #2158 (1fae6b9) into main (4846396) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2158      +/-   ##
============================================
- Coverage     61.12%   61.09%   -0.04%     
+ Complexity     3263     3261       -2     
============================================
  Files           259      259              
  Lines         18331    18332       +1     
  Branches       3250     3250              
============================================
- Hits          11205    11200       -5     
- Misses         5535     5538       +3     
- Partials       1591     1594       +3     
Impacted Files Coverage Δ
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.36% <0.00%> (-4.31%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java 85.10% <0.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cwperks
cwperks previously approved these changes Oct 12, 2022
@prudhvigodithi prudhvigodithi marked this pull request as draft October 12, 2022 19:12
@prudhvigodithi
Copy link
Contributor Author

Hey waiting on for this bug opensearch-project/OpenSearch#4733 (comment) to be fixed

@prudhvigodithi
Copy link
Contributor Author

Hey @peternied and @cwperks can you please review again?

@prudhvigodithi prudhvigodithi changed the title add group = org.opensearch.plugin add groupId = org.opensearch.plugin Oct 12, 2022
@cwperks
Copy link
Member

cwperks commented Oct 12, 2022

@prudhvigodithi Looks like we are having more build failures on the main branch after a change of dependencies in opensearch-rest-client in core. We get this dependency transitively via implementation "org.opensearch.client:opensearch-rest-high-level-client:${opensearch_version}" in the security build.gradle

See: https://github.com/opensearch-project/OpenSearch/commit/4833e080cc506237fee5aa90767d6f49d952bec3#diff-d427b66629707cb1cf8[…]97092af9c5de984b6be6ab4b

Before this is merged we should get a PR out to fix the build breaking change.

@cwperks
Copy link
Member

cwperks commented Oct 12, 2022

See relevant lines in the build output:

/home/runner/work/security/security/src/main/java/org/opensearch/security/httpclient/HttpClient.java:34: error: cannot find symbol

import org.apache.http.HttpHeaders;
> Task :compileJava
                      ^
  symbol:   class HttpHeaders
  location: package org.apache.http
/home/runner/work/security/security/src/main/java/org/opensearch/security/httpclient/HttpClient.java:[35](https://github.com/opensearch-project/security/actions/runs/3237632985/jobs/5305275039#step:5:36): error: cannot find symbol
import org.apache.http.HttpHost;

cwperks
cwperks previously approved these changes Oct 14, 2022
@cwperks
Copy link
Member

cwperks commented Oct 18, 2022

@prudhvigodithi Can you rebase this PR with the latest changes from main which includes changes that fix the build?

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
@prudhvigodithi
Copy link
Contributor Author

Hey @cwperks I have just rebased.
Thank you

@davidlago davidlago merged commit 49e7300 into opensearch-project:main Oct 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 20, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit 49e7300)
cwperks pushed a commit that referenced this pull request Oct 21, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit 49e7300)

Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Nov 10, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…ch-project#2185)

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit 49e7300)

Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants