Automatically update GitHub Actions dependencies with dependabot #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternied
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
peternied
force-pushed
the
auto-update-gha
branch
from
4fa94a6
to
f1542eb
Compare
peternied
commented
Aug 8, 2023
| @@ -10,3 +10,9 @@ updates: | |||
| # For all packages, ignore all major versions to minimize breaking issues | |||
| - dependency-name: "*" | |||
| update-types: ["version-update:semver-major"] | |||
| - package-ecosystem: "github-actions" | |||
There was a problem hiding this comment.
Why not include version-update:semver-major like was recently added onto gradle dependencies?
We have fewer (I think?) dependencies in GitHub Actions and I'd like to try it before I see lots of churn. Easy to make this change as a fast follow if there is concern.
There was a problem hiding this comment.
I think for Github actions the update to major is not as breaking as for main codebase, most do major anyway (fe codeql v1 -> v2, checkout v2 -> v3, ...)
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
force-pushed
the
auto-update-gha
branch
from
f1542eb
to
b265d96
Compare
Codecov Report
@@ Coverage Diff @@
## main #3133 +/- ##
============================================
- Coverage 62.46% 62.43% -0.04%
+ Complexity 3354 3350 -4
============================================
Files 254 254
Lines 19749 19749
Branches 3334 3334
============================================
- Hits 12336 12330 -6
- Misses 5783 5789 +6
Partials 1630 1630 |
willyborankin
approved these changes
Aug 10, 2023
reta
approved these changes
Aug 10, 2023
Merged
6 tasks
cwperks
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically update GitHub Actions dependencies with dependabot. Noticed this was possible when I was reading the notice around CodeQL's v1 deprecation, [codeql-action-v1-is-now-deprecated].
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.