Pass set to SystemIndexRegistry.matchesSystemIndexPattern

[cwperks]

Description

This PR fixes a compilation error after merge of opensearch-project/OpenSearch#14750 in core which changes the method signature to SystemIndexRegistry.matchesSystemIndexPattern to accept a set to prevent having to convert between a set and array in SystemIndexAccessEvaluator.

• Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

• New functionality includes testing
• New functionality has been documented
• New Roles/Permissions have a corresponding security dashboards plugin PR
• API changes companion pull request created
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.29%. Comparing base (cfb5525) to head (187f42c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4569      +/-   ##
==========================================
- Coverage   65.30%   65.29%   -0.01%     
==========================================
  Files         317      317              
  Lines       22274    22274              
  Branches     3582     3582              
==========================================
- Hits        14546    14544       -2     
- Misses       5936     5939       +3     
+ Partials     1792     1791       -1     

Files	Coverage Δ
...ecurity/privileges/SystemIndexAccessEvaluator.java	70.63% <100.00%> (ø)

... and 3 files with indirect coverage changes

[DarshitChanpura]

@cwperks could you look into CI failures:

Seems to be failing still for some workflows with:

Error: 7-16T16:00:34,864][ERROR][o.o.s.f.SecurityFilter   ] [smoketestnode] Unexpected exception java.lang.NoSuchMethodError: 'java.util.Set org.opensearch.indices.SystemIndexRegistry.matchesSystemIndexPattern(java.util.Set)'

[cwperks]

@DarshitChanpura This is blocked due to stale min distribution for 3.0.0. I will re-run the CI checks once fresh artifacts are available that include opensearch-project/OpenSearch#14750