Update to OpenSearch 2.10 #174
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
|
@nknize just FYI - the things we ask users to absorb as the result of refactorings |
It's the cost of OpenSearch providing a forward facing API on an Elasticsearch product that wasn't designed to provide a forward facing API. This is going to go on for as long as we don't converge on a forward facing API. We'll get there but folks shouldn't expect it to happen instantaneously. Maybe we create a meta issue to track the classes being used in downstream projects to make it easier on us properly annotating classes in the core? |
I understand that for sure, just wanted to have a live example for you :)
That could be very difficult to compile I think |
It would get long for sure (just like the flaky test meta issue). For now I've been tracking this by just referencing opensearch-project/OpenSearch#5910 so that it gets added to the audit trail for history retention. It's easier than digitally spelunking the project PRs. |
|
|
||
| try (XContentParser parser = XContentHelper.createParser( | ||
| try (XContentParser parser = org.opensearch.common.xcontent.XContentHelper.createParser( |
There was a problem hiding this comment.
We don't need the full namespace here, do we?
There was a problem hiding this comment.
Yes we do sadly, we have 2 XContentHelpers: class imports org.opensearch.core.common.xcontent.XContentHelper but this is another one
Description
Update to OpenSearch 2.10
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.