Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uppercase chars in service and plan names #433

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Jan 30, 2018

Closes #422

Signed-off-by: Doug Davis dug@us.ibm.com

@cfdreddbot
Copy link

Hey duglin!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@angarg12
Copy link
Contributor

angarg12 commented Jan 30, 2018

LGTM

Approved with PullApprove

spec.md Outdated
@@ -353,7 +359,7 @@ It is therefore RECOMMENDED that implementations avoid such strings.

| Response field | Type | Description |
| --- | --- | --- |
| name* | string | A CLI-friendly name of the service. MUST only contain lowercase characters, numbers and hyphens (no spaces). MUST be unique across all service objects returned in this response. MUST be a non-empty string. |
| name* | string | A CLI-friendly name of the service. MUST only contain alphanumerica characters and hyphens (no spaces). MUST be unique across all service objects returned in this response. MUST be a non-empty string. |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? alphanumeric

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@mattmcneeney
Copy link
Contributor

mattmcneeney commented Jan 30, 2018

LGTM

Approved with PullApprove

Closes openservicebrokerapi#422

Signed-off-by: Doug Davis <dug@us.ibm.com>
@duglin
Copy link
Contributor Author

duglin commented Jan 30, 2018

fixed typo and added text around how names are now case-sensitive

@duglin
Copy link
Contributor Author

duglin commented Feb 6, 2018

re-reviews needed due to minor tweaks

@mattmcneeney
Copy link
Contributor

mattmcneeney commented Feb 6, 2018

LGTM

Approved with PullApprove

2 similar comments
@vaikas
Copy link
Contributor

vaikas commented Feb 6, 2018

LGTM

Approved with PullApprove

@avade
Copy link
Contributor

avade commented Feb 6, 2018

LGTM

Approved with PullApprove

@zrob
Copy link
Member

zrob commented Feb 6, 2018

lgtm

Approved with PullApprove

@mattmcneeney mattmcneeney merged commit 6e0bf7d into openservicebrokerapi:master Feb 6, 2018
@duglin duglin deleted the Issue422 branch March 2, 2018 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants