Improve text assertions #2236
Merged
Improve text assertions #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
mareklibra
approved these changes
Jun 30, 2023
jgyselov
approved these changes
Jun 30, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: celdrake, jgyselov, mareklibra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rawagner
pushed a commit
to rawagner/facet-lib
that referenced
this pull request
Sep 13, 2023
* Improve logging of text check failures * Display the actual found text on failures * Fix incorrect use of selectors instead of text assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.should('contain')which doesn't output the expected result. That makes debugging the issue harder.We should use
.should('contain.text')which prints what text it found instead of the expected one..contains(text)to validate the text content. But this is not an assertion, rather it's a selector. I've changed the incorrect uses of.containsto.should('contain.text').