Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17236: Add aria label property to close button in host status popover to help cypress tests #2520

Conversation

ammont82
Copy link
Contributor

Related to https://issues.redhat.com/browse/MGMT-17236

Add "aria-label" property to close button in host status popover to help cypress tests:

image

@ammont82 ammont82 added the OCM label Mar 15, 2024
@ammont82 ammont82 added this to the v2.31 milestone Mar 15, 2024
@ammont82 ammont82 requested a review from a team as a code owner March 15, 2024 13:26
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2024

@ammont82: This pull request references MGMT-17236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17236

Add "aria-label" property to close button in host status popover to help cypress tests:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2024

@ammont82: This pull request references MGMT-17236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17236

Add "aria-label" property to close button in host status popover to help cypress tests:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 merged commit d920ef6 into openshift-assisted:master Mar 15, 2024
7 checks passed
@ammont82 ammont82 removed this from the v2.31 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OCM size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants