Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-17130: Add correct id to <HelperItem> components when shown errors - 2.31 #2527

Merged
merged 2 commits into from
Mar 20, 2024
Merged

MGMT-17130: Add correct id to <HelperItem> components when shown errors - 2.31 #2527

merged 2 commits into from
Mar 20, 2024

Conversation

ammont82
Copy link
Contributor

backport of #2517

@ammont82
MGMT-17130: Add correct id to <HelperItem> components when shown erro…
2e24369 
…rs (openshift-assisted#2517)

* Add id to HelperItem components to indicate errors

* Add tests for validations in New cluster page

* Changing id in HelperItem components to show errors
@ammont82 ammont82 added this to the v2.31 milestone Mar 20, 2024
@ammont82 ammont82 requested a review from a team as a code owner March 20, 2024 09:44
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17130 which is a valid jira issue.

In response to this:

backport of #2517

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17130 which is a valid jira issue.

In response to this:

backport of #2517

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2024

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit 71ab4fb into openshift-assisted:releases/v2.31 Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celdrake celdrake celdrake approved these changes

@jgyselov jgyselov jgyselov approved these changes

Assignees

@celdrake celdrake

@jgyselov jgyselov

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v2.31
Development

Successfully merging this pull request may close these issues.
4 participants
@ammont82 @openshift-ci-robot @celdrake @jgyselov