Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-17377: Change the way to validate field values in networking page #2534

Merged
merged 1 commit into from
Apr 3, 2024
Merged

MGMT-17377: Change the way to validate field values in networking page #2534

merged 1 commit into from
Apr 3, 2024

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 commented Apr 2, 2024 •
edited
Loading

Related to https://issues.redhat.com/browse/MGMT-17377

Validate field values in Networking page:

Captura desde 2024-04-02 15-04-21
Captura desde 2024-04-02 15-04-14
Captura desde 2024-04-02 15-04-04

@ammont82 ammont82 requested a review from a team as a code owner April 2, 2024 13:13
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2024
@ammont82 ammont82 added the OCM label Apr 2, 2024
@ammont82 ammont82 added this to the v2.31 milestone Apr 2, 2024
@ammont82 ammont82 force-pushed the MGMT-17377-all-network-page-fields-are-not-validating-values branch from 009105c to 347bd1c Compare April 2, 2024 13:14
jgyselov
jgyselov previously approved these changes Apr 3, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@jgyselov jgyselov changed the title MGMT-173Change the way to validate field values in networking page MGMT-173: Change the way to validate field values in networking page Apr 3, 2024
@openshift-ci-robot
Copy link

@ammont82: No Jira issue with key MGMT-173 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17377

Validate field values in Networking page:

Captura desde 2024-04-02 15-04-21
Captura desde 2024-04-02 15-04-14
Captura desde 2024-04-02 15-04-04

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgyselov jgyselov changed the title MGMT-173: Change the way to validate field values in networking page MGMT-17377: Change the way to validate field values in networking page Apr 3, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17377 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17377

Validate field values in Networking page:

Captura desde 2024-04-02 15-04-21
Captura desde 2024-04-02 15-04-14
Captura desde 2024-04-02 15-04-04

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 force-pushed the MGMT-17377-all-network-page-fields-are-not-validating-values branch from 347bd1c to f2b54fc Compare April 3, 2024 10:01
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2024
@ammont82 ammont82 requested a review from jgyselov April 3, 2024 10:03
jgyselov
jgyselov previously approved these changes Apr 3, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@ammont82 ammont82 dismissed stale reviews from celdrake and jgyselov via 1d3f3f3 April 3, 2024 11:41
@ammont82 ammont82 force-pushed the MGMT-17377-all-network-page-fields-are-not-validating-values branch from f2b54fc to 1d3f3f3 Compare April 3, 2024 11:41
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 990df8c into openshift-assisted:master Apr 3, 2024
7 checks passed
ammont82 added a commit to ammont82/assisted-installer-ui that referenced this pull request Apr 3, 2024
@ammont82
Change the way to validate field values in networking page (openshift…
e7c5e78 
…-assisted#2534)
@ammont82 ammont82 mentioned this pull request Apr 3, 2024
Merged
ammont82 added a commit that referenced this pull request Apr 3, 2024
@ammont82
Change the way to validate field values in networking page (#2534) (#…
2276680 
…2535)
jgyselov pushed a commit to jgyselov/assisted-installer-ui that referenced this pull request May 29, 2024
@ammont82 @jgyselov
Change the way to validate field values in networking page (openshift…
8354657 
…-assisted#2534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celdrake celdrake celdrake approved these changes

@jgyselov jgyselov jgyselov approved these changes

Assignees

@celdrake celdrake

@jgyselov jgyselov

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v2.31
Development

Successfully merging this pull request may close these issues.
4 participants
@ammont82 @openshift-ci-robot @celdrake @jgyselov