MGMT-17473: Add scrollbar to OpenshiftVersionDropdown component

[ammont82]

Related to https://issues.redhat.com/browse/MGMT-17473

Adding scrollbar to OpenshiftVersionDropdown component avoid problems about changing window layout.

[openshift-ci-robot]

@ammont82: This pull request references MGMT-17473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17473

Adding scrollbar to OpenshiftVersionDropdown component avoid problems about changing window layout.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[celdrake]

The scrollbar works well.

However, I just noticed a small layout change. When the additional versions modal opens, the main version dropdown stays open too. But as you click on the text input to select the custom version, the main version dropdown closes on the background.

IMO, it should either stay open until the modal is closed, or it should close when the modal is open.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jgyselov]

We are using the deprecated version of the Dropdown component. (See dropdown/react-deprecated vs dropdown.)

The newer version supports a flip behavior - if the dropdown doesn't have enough space bellow the toggle, it tries to render it above.

Maybe this is a good opportunity to migrate?

[jgyselov]

Also, I noticed that when we limit the height of the dropdown, the "Show all available versions" button is hidden at the bottom. I find that a bit unfortunate.

[ammont82]

We are using the deprecated version of the Dropdown component. (See dropdown/react-deprecated vs dropdown.)

The newer version supports a flip behavior - if the dropdown doesn't have enough space bellow the toggle, it tries to render it above.

Maybe this is a good opportunity to migrate?

@jgyselov is not so easy migrate to new Dropdown version. It implies a lot of changes and we need to take a look carefully. I'll open a task to do in the future.

[openshift-ci]

New changes are detected. LGTM label has been removed.