Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-17569: Patch Manifest - Second attempt to upload invalid content of manifest not declined #2561

Merged
merged 1 commit into from
Apr 19, 2024
Merged

MGMT-17569: Patch Manifest - Second attempt to upload invalid content of manifest not declined #2561

merged 1 commit into from
Apr 19, 2024

Conversation

ammont82
Copy link
Contributor

Related to https://issues.redhat.com/browse/MGMT-17569

Validate every updated manifest when user changes something (folder, file name or content)

update_manifests.mp4

@ammont82 ammont82 added the OCM label Apr 18, 2024
@ammont82 ammont82 requested a review from a team as a code owner April 18, 2024 09:00
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17569 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17569

Validate every updated manifest when user changes something (folder, file name or content)

update_manifests.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 18, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 1857ec6 into openshift-assisted:master Apr 19, 2024
7 checks passed
ammont82 added a commit to ammont82/assisted-installer-ui that referenced this pull request Apr 19, 2024
@ammont82
Validate every updated manifest when user changes something (folder, …
aaf1d4d 
…file name or content) (openshift-assisted#2561)
@ammont82 ammont82 mentioned this pull request Apr 19, 2024
Merged
ammont82 added a commit that referenced this pull request Apr 19, 2024
@ammont82
Validate every updated manifest when user changes something (folder, …
eac2f42 
…file name or content) (#2561) (#2562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celdrake celdrake celdrake approved these changes

@jgyselov jgyselov jgyselov approved these changes

Assignees

@celdrake celdrake

@jgyselov jgyselov

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ammont82 @openshift-ci-robot @celdrake @jgyselov