Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE Use ReactDOM 18 functions #2569

Merged
merged 2 commits into from
May 15, 2024

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov commented Apr 26, 2024

Resolves this little warning in the app.

image

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 26, 2024
@jgyselov jgyselov changed the title Migrate to ReactDOM 18 functions NO-ISSUE Use ReactDOM 18 functions Apr 29, 2024
@jgyselov jgyselov marked this pull request as ready for review April 29, 2024 12:44
@jgyselov jgyselov requested a review from a team as a code owner April 29, 2024 12:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link

openshift-ci bot commented May 15, 2024

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit 32c843f into openshift-assisted:master May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants