Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16985: Not allow to remove nodes in day2 cluster #2570

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 commented May 2, 2024

Related to https://issues.redhat.com/browse/MGMT-16985

In day2, Nodes can be removed after they are installed. Day1 hosts can't be removed after they are installed.

  • Before changes:

Captura desde 2024-05-02 12-19-35

  • After changes:

Captura desde 2024-05-02 12-22-23

@ammont82 ammont82 added the OCM label May 2, 2024
@ammont82 ammont82 added this to the v2.32 milestone May 2, 2024
@ammont82 ammont82 requested a review from a team as a code owner May 2, 2024 10:24
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2024

@ammont82: This pull request references MGMT-16985 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-16985

In day2, Nodes can be removed after they are installed. Day1 hosts can't be removed after they are installed.

  • Before changes:

Captura desde 2024-05-02 12-19-35

  • After changes:

Captura desde 2024-05-02 12-19-35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2024

@ammont82: This pull request references MGMT-16985 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-16985

In day2, Nodes can be removed after they are installed. Day1 hosts can't be removed after they are installed.

  • Before changes:

Captura desde 2024-05-02 12-19-35

  • After changes:

Captura desde 2024-05-02 12-22-23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@ammont82 ammont82 requested a review from celdrake May 7, 2024 11:08
Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
Copy link

openshift-ci bot commented May 8, 2024

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit 728bd80 into openshift-assisted:master May 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OCM size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants