Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16745: Add platform field to R&C and installation pages #2648

Merged

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov requested a review from a team as a code owner July 31, 2024 09:57
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2024

@jgyselov: This pull request references MGMT-16745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-16745

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov added this to the v2.34 milestone Jul 31, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2024
@ammont82
Copy link
Contributor

ammont82 commented Aug 5, 2024

@jgyselov about the PlatformIntegrationNote:

  • In case of Nutanix and vSphere - it's necessary
  • In case of OCI - it's not necessary

@ammont82 ammont82 merged commit fb7ebd8 into openshift-assisted:master Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants