Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19008: CNV should be dev preview in case CPU is ARM64 #2673

Conversation

ammont82
Copy link
Contributor

Related to https://issues.redhat.com/browse/MGMT-19008

We add the code to show PreviewBadge in CNV operator label (in Operators page) when is necessary.

For example, for clusters with OCP 4.16+ ARM64 we need to show the DevPreviewBadge:
Captura desde 2024-09-26 11-14-45

@ammont82 ammont82 added the OCM label Sep 26, 2024
@ammont82 ammont82 added this to the v2.35 milestone Sep 26, 2024
@ammont82 ammont82 requested a review from a team as a code owner September 26, 2024 09:18
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@ammont82: This pull request references MGMT-19008 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-19008

We add the code to show PreviewBadge in CNV operator label (in Operators page) when is necessary.

For example, for clusters with OCP 4.16+ ARM64 we need to show the DevPreviewBadge:
Captura desde 2024-09-26 11-14-45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 26, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@ammont82: This pull request references MGMT-19008 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-19008

We add the code to show PreviewBadge in CNV operator label (in Operators page) when is necessary.

For example, for clusters with OCP 4.16+ ARM64 we need to show the DevPreviewBadge:
Captura desde 2024-09-26 11-14-45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

openshift-ci bot commented Sep 26, 2024

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit 7798c90 into openshift-assisted:master Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OCM size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants