Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] Use istio inject label #1290

Open
wants to merge 1 commit into
base: release-v1.15
Choose a base branch
from

Conversation

matzew
Copy link
Member

@matzew matzew commented Sep 27, 2024

Ref: knative/eventing#8204

backport

Ref: knative/eventing#8204

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and creydr September 27, 2024 05:14
Copy link

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 27, 2024

@matzew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-conformance-aws-416 df2ddf2 link true /test 416-test-conformance-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew can you re-run make generate-release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants