Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update the images-rekt.yaml on make release-files #2235

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 15, 2023

Follow up on #2233 to auto update the image-rekt.yaml file, when the version gets bumped and make release-files is run.

@openshift-ci openshift-ci bot requested review from alanfx and pierDipi August 15, 2023 08:00
@creydr
Copy link
Member Author

creydr commented Aug 15, 2023

/assign @matzew

@creydr
Copy link
Member Author

creydr commented Aug 15, 2023

/cc @mgencur

@openshift-ci openshift-ci bot requested a review from mgencur August 15, 2023 08:15
@matzew
Copy link
Member

matzew commented Aug 15, 2023

See related PR: #2236

(I triggered the GA action, for main - manually)

@mgencur
Copy link
Contributor

mgencur commented Aug 15, 2023

I had this one assigned: https://issues.redhat.com/browse/SRVCOM-2649
You're already working on generating the image file. But it would be good to generated the file with multiarch images which are one quay (built by github action).

@creydr
Copy link
Member Author

creydr commented Aug 15, 2023

I had this one assigned: https://issues.redhat.com/browse/SRVCOM-2649 You're already working on generating the image file. But it would be good to generated the file with multiarch images which are one quay (built by github action).

@mgencur: Are all images from https://quay.io/repository/openshift-knative/eventing/ multiarch images? Or where can I find the list of available multiarch images? (because I could simply use them e.g. in

export KNATIVE_EVENTING_HEARTBEATS=${KNATIVE_EVENTING_HEARTBEATS:-"${eventing}-heartbeats:${tag}"}
then)

@mgencur
Copy link
Contributor

mgencur commented Aug 15, 2023

@mgencur: Are all images from https://quay.io/repository/openshift-knative/eventing/ multiarch images?

Right now, all test images are multiarch. Not core images.

@creydr
Copy link
Member Author

creydr commented Aug 15, 2023

@mgencur updated it to use the multiarch images for the eventing-test images and heartbeats (a64f8f4)

@mgencur
Copy link
Contributor

mgencur commented Aug 15, 2023

@mgencur updated it to use the multiarch images for the eventing-test images and heartbeats (a64f8f4)

Nice!

@creydr creydr force-pushed the auto-update-images-rekt.yaml branch from a64f8f4 to 06520d4 Compare August 15, 2023 14:37
@creydr
Copy link
Member Author

creydr commented Aug 15, 2023

Rebased

@mgencur
Copy link
Contributor

mgencur commented Aug 16, 2023

/lgtm
/hold

Feel free to unhold if you want to fix the nit later.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Aug 16, 2023

/lgtm /hold

Feel free to unhold if you want to fix the nit later.

I will fix it in a separate PR to get this unblocked

/unhold

@openshift-merge-robot openshift-merge-robot merged commit b738947 into openshift-knative:main Aug 16, 2023
3 checks passed
@creydr creydr deleted the auto-update-images-rekt.yaml branch May 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants