Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tests with lots of resources #2239

Merged
merged 42 commits into from
Sep 18, 2023
Merged

Upgrade tests with lots of resources #2239

merged 42 commits into from
Sep 18, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 21, 2023 •
edited
Loading

Fixes https://issues.redhat.com/browse/SRVCOM-2138
Fixes https://issues.redhat.com/browse/SRVCOM-2377

Note: Mostly complete. I just want to see it passing in CI.

Proposed Changes

  • Add kitchensink tests for sources (PingSource, ContainerSource, KafkaSource, ApiServerSource)
  • Run kitchensink tests during upgrades. Multiple copies of resources are created, this is defined via NumDeployments const that equals 3. This is the maximum that a cluster with 5 workers can accomodate without running out of mem/cpu.

With current NumDeployments==3, these resources are deployed for the upgrade stress test:

Resource apiserversources.sources.knative.dev: 3
Resource brokers.eventing.knative.dev: 72
Resource certificates.networking.internal.knative.dev: 0
Resource channels.messaging.knative.dev: 54
Resource clusterdomainclaims.networking.internal.knative.dev: 0
Resource configurations.serving.knative.dev: 144
Resource consumergroups.internal.kafka.eventing.knative.dev: 3
Resource consumers.internal.kafka.eventing.knative.dev: 3
Resource containersources.sources.knative.dev: 3
Resource domainmappings.serving.knative.dev: 0
Resource eventtypes.eventing.knative.dev: 0
Resource images.caching.internal.knative.dev: 145
Resource ingresses.networking.internal.knative.dev: 144
Resource inmemorychannels.messaging.knative.dev: 216
Resource kafkachannels.messaging.knative.dev: 222
Resource kafkasinks.eventing.knative.dev: 20
Resource kafkasources.sources.knative.dev: 3
Resource knativeeventings.operator.knative.dev: 1
Resource knativekafkas.operator.serverless.openshift.io: 1
Resource knativeservings.operator.knative.dev: 1
Resource metrics.autoscaling.internal.knative.dev: 144
Resource parallels.flows.knative.dev: 50
Resource pingsources.sources.knative.dev: 3
Resource podautoscalers.autoscaling.internal.knative.dev: 144
Resource revisions.serving.knative.dev: 144
Resource routes.serving.knative.dev: 144
Resource sequences.flows.knative.dev: 50
Resource serverlessservices.networking.internal.knative.dev: 144
Resource services.serving.knative.dev: 144
Resource sinkbindings.sources.knative.dev: 3
Resource subscriptions.messaging.knative.dev: 480
Resource triggers.eventing.knative.dev: 234

@openshift-ci openshift-ci bot requested review from alanfx and skonto August 21, 2023 15:17
@mgencur
Copy link
Contributor Author

mgencur commented Aug 21, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2023

@mgencur: The following commands are available to trigger required jobs:

  • /test 4.10-images
  • /test 4.10-operator-e2e-aws-ocp-410
  • /test 4.10-ui-tests
  • /test 4.13-aws-ovn-images
  • /test 4.13-azure-images
  • /test 4.13-gcp-images
  • /test 4.13-hypershift-images
  • /test 4.13-images
  • /test 4.13-operator-e2e-aws-ocp-413
  • /test 4.13-osd-images
  • /test 4.13-single-node-images
  • /test 4.13-ui-tests
  • /test 4.13-vsphere-images
  • /test ocp4.14-lp-interop-images
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test 4.10-e2e-kitchensink-ocp-410
  • /test 4.10-upgrade-kitchensink-ocp-410
  • /test 4.10-upgrade-tests-aws-ocp-410
  • /test 4.10-upstream-e2e-aws-ocp-410
  • /test 4.10-upstream-e2e-kafka-aws-ocp-410
  • /test 4.10-upstream-e2e-mesh-aws-ocp-410
  • /test 4.13-e2e-kitchensink-ocp-413
  • /test 4.13-upgrade-kitchensink-ocp-413
  • /test 4.13-upgrade-tests-aws-ocp-413
  • /test 4.13-upstream-e2e-aws-ocp-413
  • /test 4.13-upstream-e2e-kafka-aws-ocp-413
  • /test 4.13-upstream-e2e-mesh-aws-ocp-413

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-knative-serverless-operator-main-4.10-images
  • pull-ci-openshift-knative-serverless-operator-main-4.13-aws-ovn-images
  • pull-ci-openshift-knative-serverless-operator-main-4.13-azure-images
  • pull-ci-openshift-knative-serverless-operator-main-4.13-gcp-images
  • pull-ci-openshift-knative-serverless-operator-main-4.13-hypershift-images
  • pull-ci-openshift-knative-serverless-operator-main-4.13-images
  • pull-ci-openshift-knative-serverless-operator-main-4.13-operator-e2e-aws-ocp-413
  • pull-ci-openshift-knative-serverless-operator-main-4.13-osd-images
  • pull-ci-openshift-knative-serverless-operator-main-4.13-single-node-images
  • pull-ci-openshift-knative-serverless-operator-main-4.13-upgrade-tests-aws-ocp-413
  • pull-ci-openshift-knative-serverless-operator-main-4.13-upstream-e2e-aws-ocp-413
  • pull-ci-openshift-knative-serverless-operator-main-4.13-upstream-e2e-kafka-aws-ocp-413
  • pull-ci-openshift-knative-serverless-operator-main-4.13-vsphere-images
  • pull-ci-openshift-knative-serverless-operator-main-ocp4.14-lp-interop-images
  • pull-ci-openshift-knative-serverless-operator-main-unit-test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link
Contributor Author

mgencur commented Aug 21, 2023

/test 4.10-upgrade-kitchensink-ocp-410

This is temporarily an alias for test-kitchensink-upgrade-stress. Just for testing purposes in this PR, before we create specific CI configuration.

@mgencur
Copy link
Contributor Author

mgencur commented Aug 22, 2023

/test 4.10-upgrade-kitchensink-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Aug 25, 2023

/test 4.10-upgrade-kitchensink-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Aug 29, 2023

/test 4.10-upgrade-kitchensink-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Aug 29, 2023

/test 4.10-upgrade-kitchensink-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Aug 30, 2023

/test 4.10-upgrade-kitchensink-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Aug 30, 2023

/test 4.10-upgrade-kitchensink-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Sep 13, 2023

/test 4.10-upgrade-kitchensink-ocp-410

2 similar comments
@mgencur
Copy link
Contributor Author

mgencur commented Sep 13, 2023

/test 4.10-upgrade-kitchensink-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Sep 14, 2023

/test 4.10-upgrade-kitchensink-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Sep 14, 2023

The kitchensink upgrade stress tests passed in the previous run. Now removing the temporary alias in Makefile.

@mgencur
Copy link
Contributor Author

mgencur commented Sep 14, 2023

4.13-upstream-e2e-aws-ocp-413

@mgencur
Copy link
Contributor Author

mgencur commented Sep 14, 2023

/test 4.13-upstream-e2e-aws-ocp-413

@mgencur mgencur changed the title [WIP] Upgrade tests with lots of resources Upgrade tests with lots of resources Sep 14, 2023
@mgencur
Copy link
Contributor Author

mgencur commented Sep 14, 2023

/retest

@maschmid
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 60de240 into openshift-knative:main Sep 18, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanfx alanfx Awaiting requested review from alanfx

@skonto skonto Awaiting requested review from skonto

Assignees

@maschmid maschmid

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgencur @maschmid @openshift-merge-robot