[release-1.32] Verify promotion tag for patch releases #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
/hold |
|
/test 415-test-upgrade-aws-415 |
|
/unhold |
matzew
approved these changes
Jul 23, 2024
mgencur
reviewed
Jul 23, 2024
|
|
||
| if [ $count -ne 0 ]; then | ||
| echo "## $count files with an unexpected promotion name or tag" | ||
| echo "1. Use the [release-generate-ci](https://github.com/openshift-knative/serverless-operator/actions/workflows/release-generate-ci.yaml?query=branch%3Arelease-1.33) GH actions workflow in serverless-operator on the $release branch with inputs:" |
There was a problem hiding this comment.
Should this query point to release-1.33? This PR is against release-1.32
There was a problem hiding this comment.
Added it as a variable and it should point to 1.32 for this branch
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
merged commit b362a40
into
openshift-knative:release-1.32
6 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2755