Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registry.redhat.io reference in CSV #2920

Merged
merged 11 commits into from
Oct 7, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Oct 7, 2024

Related slack discussion

Proposed Changes

  • When building Bundle image in CI, replace the references back to Konflux quay.io in the CSV being used. This is for testing purposes.
  • When using an external Index image that was built earlier, generate an ImageContentSourcePolicy as we can't directly manipulate the CSV. This ICSP will redirect OpenShift to pull image from different locations (Konflux workspace in quay instead of registry.redhat.io)
  • Do not use registry.redhat.io for bundle image itself in the catalog otherwise the Konflux build for Index image fails as it can't pull the image from registry.redhat.io. The catalog needs to be reworked as part of https://issues.redhat.com/browse/SRVCOM-3369 anyway.

@mgencur mgencur changed the title [WIP] Use registry.redhat.io reference in CSV and index catalog Use registry.redhat.io reference in CSV and index catalog Oct 7, 2024
@mgencur mgencur changed the title Use registry.redhat.io reference in CSV and index catalog Use registry.redhat.io reference in CSV Oct 7, 2024
@pierDipi
Copy link
Member

pierDipi commented Oct 7, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-upgrade-aws-416 89e6364 link true /test 416-test-upgrade-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5cc8af0 and 2 for PR HEAD 89e6364 in total

@mgencur
Copy link
Contributor Author

mgencur commented Oct 7, 2024

The failure from upgrade tests will be fixed by #2921

@pierDipi pierDipi merged commit a07792f into openshift-knative:main Oct 7, 2024
14 of 16 checks passed
@pierDipi
Copy link
Member

pierDipi commented Oct 7, 2024

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants