Fix konflux index and bundle cel expressions to avoid build loops #2924
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
changed the title
| @@ -8,7 +8,7 @@ metadata: | |||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | |||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | |||
| pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch | |||
| == "main" | |||
| == "main" && ( files.all.exists(x, !x.matches('^olm-catalog/')) || files.all.exists(x, x.matches('^.tekton/')) ) | |||
There was a problem hiding this comment.
Not sure if we need to have the files.all.exists(x, x.matches('^.tekton/'), as as long we don't have only changes in olm-catalog/ we can build the ingress.
Probably similar in the other components.
There was a problem hiding this comment.
agree, I will fix it on the hack PR as this change is mostly to make it work, ok?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
probably as we need to regenerate the ci config with the new paths |
|
Yes, hack repo change incoming |
|
openshift-knative/hack#320 that will fix CI |
|
@pierDipi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fix the bundle + index build looping
Change index directory from being within bundle manifests to be it's own under
olm-catalog/serverless-operator-indexI will port this changes to the hack repo once merged