-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-18913: Add support for external load balancer #6865
base: master
Are you sure you want to change the base?
MGMT-18913: Add support for external load balancer #6865
Conversation
@jhernand: This pull request references MGMT-18913 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhernand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 68.74% 68.67% -0.08%
==========================================
Files 249 249
Lines 37439 37459 +20
==========================================
- Hits 25739 25725 -14
- Misses 9402 9432 +30
- Partials 2298 2302 +4
|
46fa071
to
9979cbe
Compare
@jhernand: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
9979cbe
to
867aafa
Compare
This patch adds support for using an external load balancer. It will only be available for OpenShift 4.16 or newer. To enable it the user will have to use the new `load_balancer.type` field of the `cluster` type, for example: ```json { ... "load_balancer": { "type": "user-managed" } } ``` To preserve backwards compatibility this will be optional, and the default value will be `cluster-managed`. When the value is `user-managed` the following will be added to the generated `install-config.yaml` file: ```yaml platform: baremetal: loadBalancer: type: UserManaged ``` Or for _vSphere_: ``` platform: vsphere: loadBalancer: type: UserManaged ``` The database will be automatically migrated so that for existing clusters the value of the `load_balancer_type` column will automatically be set to `cluster-managed`. Note that this patch adds this support only for the `baremetal` and `vsphere` platforms. Related: https://issues.redhat.com/browse/MGMT-18913 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
867aafa
to
49ae18e
Compare
This patch adds support for using an external load balancer. It will only be available for OpenShift 4.16 or newer. To enable it the user will have to use the new
load_balancer.type
field of thecluster
type, for example:To preserve backwards compatibility this will be optional, and the
default value will be
cluster-managed
.When the value is
user-managed
the following will be added to thegenerated
install-config.yaml
file:The database will be automatically migrated so that for existing
clusters the value of the
load_balancer_type
column will automaticallybe set to
cluster-managed
.List all the issues related to this PR
https://issues.redhat.com/browse/MGMT-18913
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist