OCPBUGS-31384: use RotatedSigningCASecret and RotatedSelfSignedCertKeySecret only in update mode #800
Conversation
|
/assign @tkashem |
p0lyn0mial
changed the title
|
/hold requires openshift/kubernetes#1924 |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retitle "OCPBUGS-31384: use RotatedSigningCASecret and RotatedSelfSignedCertKeySecret only in update mode" |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@p0lyn0mial: This pull request references Jira Issue OCPBUGS-31384, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retitle OCPBUGS-31384: use RotatedSigningCASecret and RotatedSelfSignedCertKeySecret only in update mode |
openshift-ci
bot
changed the title
|
/retest-required |
|
Once openshift/kubernetes#1924 merges the issue should be resolved but as a follow-up we should change the type of the secret for new clusters. |
How long the short is? |
We haven't decided yet but we will be working on a fix this release - not sure if we will be able to finish the work. |
|
/retest-required |
|
/cc @vrutkovs |
|
It looks like the test is flaky, it also failed on: |
|
/retest-required |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required
|
|
/approve |
openshift-ci
bot
added
the
approved
|
failing |
openshift-merge-robot
added
the
needs-rebase
p0lyn0mial
force-pushed
the
pick-library-go-1705
branch
from
df76cf3
to
fee641d
Compare
…seSecretUpdateOnly UseSecretUpdateOnly is intended as a short term hack for a very specific use case, and it works in tandem with a particular carry patch applied to the openshift kube-apiserver. (openshift/kubernetes#1924) we will remove this when we migrate all of the affected secret objects to their intended type: https://issues.redhat.com/browse/API-1800 in short tls secrets used by this operator are reconciled by multiple controllers at the same time without any coordination. the issue is that the secret's crypto material can be regenerated, which has serious consequences for the platform as it can break external clients and the cluster itself.
p0lyn0mial
force-pushed
the
pick-library-go-1705
branch
from
fee641d
to
bff737c
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, p0lyn0mial, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@p0lyn0mial: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@p0lyn0mial: Jira Issue OCPBUGS-31384: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-31384 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-kube-controller-manager-operator-container-v4.16.0-202404040113.p0.g05f385d.assembly.stream.el9 for distgit ose-cluster-kube-controller-manager-operator. |
UseSecretUpdateOnly is intended as a short term hack for a very specific use case,
and it works in tandem with a particular carry patch applied to the openshift kube-apiserver.
(openshift/kubernetes#1924)
we will remove this when we migrate all of the affected secret
objects to their intended type: https://issues.redhat.com/browse/API-1800
in short tls secrets used by this operator are reconciled
by multiple controllers (the cert controller run by the operator and the same controller run by the recovery pod) at the same time without any coordination.
the issue is that the secret's crypto material
can be regenerated, which has serious consequences for the platform
as it can break external clients and the cluster itself.
xref: openshift/library-go#1705
xref: openshift/kubernetes#1924