Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP API-1802: Remove RefreshOnlyWhenExpired, run cert-rotation controller as sidecar to the operator #811

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP API-1802: Remove RefreshOnlyWhenExpired, run cert-rotation controller as sidecar to the operator #811

wants to merge 3 commits into from

Conversation

vrutkovs
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 30, 2024 •
edited by openshift-ci bot
Loading

@vrutkovs: This pull request references API-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
@openshift-ci openshift-ci bot requested review from deads2k and soltysh May 30, 2024 11:22
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2024
@vrutkovs vrutkovs force-pushed the cert-rotation-remove-refreshOnlyWhenExpired branch from 298f86c to 3f2193a Compare June 27, 2024 06:33
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the cert-rotation-remove-refreshOnlyWhenExpired branch 2 times, most recently from 4efc5b2 to d934c38 Compare July 1, 2024 10:16
@vrutkovs
Bump library-go
f35822d
@vrutkovs
Remove RefreshOnlyWhenExpired
ddd9e7e 
That makes cert-rotation controllers uniform to do proper leader election
@vrutkovs vrutkovs force-pushed the cert-rotation-remove-refreshOnlyWhenExpired branch from d934c38 to e3b34f9 Compare July 29, 2024 11:20
@vrutkovs
certrotationcontroller: ensure that secrets/configmaps are unique
7dc1bf8 
Collect a list of secrets/configmaps tracked in controllers to
make sure any secret/configmap is not being declared twice
to avoid races when updating it
@vrutkovs vrutkovs force-pushed the cert-rotation-remove-refreshOnlyWhenExpired branch from e3b34f9 to 7dc1bf8 Compare July 29, 2024 11:41
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 29, 2024

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrutkovs @openshift-ci-robot @openshift-merge-robot