Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-39333: E2E: Add support for hypershift to ovs dynamic pinning and kubelet.experimental annotation tests #1150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

OCPBUGS-39333: E2E: Add support for hypershift to ovs dynamic pinning and kubelet.experimental annotation tests #1150

wants to merge 3 commits into from
+136 −139

Conversation

mrniranjan
Copy link
Contributor

@mrniranjan mrniranjan commented Sep 2, 2024 •
edited
Loading

  • use appropriate resource pool nodepools for hypershift and mcp for regular cluster
  • replace dataplane test client instead of generic testclient.Client

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrniranjan
Once this PR has been reviewed and has the lgtm label, please assign jmencak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrniranjan mrniranjan changed the title E2E: Add support for hypershift to ovs dynamic pinning tests OCPBUGS-39333: E2E: Add support for hypershift to ovs dynamic pinning tests Sep 2, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 2, 2024
@openshift-ci-robot
Copy link
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-39333, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Changes primarily done to check nodepools instead of mcp for hypershift.

  • Also using appropriate dataplane test client instead of generic testclient.Client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 2, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@mrniranjan: This pull request references Jira Issue OCPBUGS-39333, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Changes primarily done to check nodepools instead of mcp for hypershift.

  • Also using appropriate dataplane test client instead of generic testclient.Client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-39333, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

In response to this:

  • use appropriate resource pool nodepools for hypershift and mcp for regular cluster
  • replace dataplane test client instead of generic testclient.Client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@mrniranjan: This pull request references Jira Issue OCPBUGS-39333, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

In response to this:

  • use appropriate resource pool nodepools for hypershift and mcp for regular cluster
  • replace dataplane test client instead of generic testclient.Client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrniranjan
Copy link
Contributor Author

/retest-required

@mrniranjan mrniranjan force-pushed the cgroups_hypershift branch 2 times, most recently from 50a6bed to e4c0635 Compare September 8, 2024 08:44
@mrniranjan mrniranjan changed the title OCPBUGS-39333: E2E: Add support for hypershift to ovs dynamic pinning tests OCPBUGS-39333: E2E: Add support for hypershift to ovs dynamic pinning and kubelet.experimental annotation tests Sep 8, 2024
@mrniranjan mrniranjan force-pushed the cgroups_hypershift branch 3 times, most recently from 6e6ab17 to 20aafcf Compare September 22, 2024 12:14
E2E: Add support for hypershift to ovs dynamic pinning tests
be53b4d 
- Changes primarily done to check nodepools instead of mcp for hypershift.
- Also using appropriate dataplane test client instead of generic testclient.Client

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@mrniranjan mrniranjan force-pushed the cgroups_hypershift branch 3 times, most recently from 62628dd to b4edf8a Compare September 22, 2024 12:52
@mrniranjan
Copy link
Contributor Author

/test e2e-aws-ovn-techpreview

Niranjan M.R added 2 commits September 23, 2024 16:31
E2E: Add hypershift for kubelet experimental annotation suite
446948b 
- Changes primarily done to check nodepools instead of mcp for hypershift.
- Also using appropriate dataplane test client instead of generic testclient.Client

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
E2E: use testclient.ControlPlaneClient for creating namespaces
8e13645 
- using testclient.ControlPlaneClient allows to the client
to be used in hypershift and regular cluster

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak Awaiting requested review from jmencak

@rbaturov rbaturov Awaiting requested review from rbaturov

Assignees
No one assigned
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrniranjan @openshift-ci-robot