Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create user-data secret for each MCP #319

Closed
michaelgugino opened this issue May 12, 2020 · 24 comments
Closed

Automatically create user-data secret for each MCP #319

michaelgugino opened this issue May 12, 2020 · 24 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@michaelgugino
Copy link
Contributor

Currently, the installer creates the initial user-data (stub ignition file) that is provided to machines on first boot to configure the host. This ignition stub contains a url that specifies the name of a MachineConfigPool. If a user creates a custom MachineConfigPool, the user must create a new stub ignition file manually, which is quite tedious.

We should automatically generate a new user-data secret for each MachineConfigPool created by the MCO. This would allow users to more easily consume custom MCPs via the machine-api by just specifying the corresponding user-data secret.

@sdodson
Copy link
Member

sdodson commented May 15, 2020

Sounds good to me.

@runcom
Copy link
Member

runcom commented Jun 23, 2020

SGTM as well but I don't think this prevents #368 from landing and the plan around managing this user data (as well as bootimages) from the MCO isn't fully hashed out either, see openshift/machine-config-operator#683 (comment) (that's yet another direction...). So, I think this would be valuable as well and we can work on something for the next release (#368 is specific for the v3 migration which is tricky per-se and we want to avoid to pull in other changes like this could be..)

@runcom
Copy link
Member

runcom commented Jun 23, 2020

/cc @enxebre @cgwalters

@cgwalters
Copy link
Member

This is openshift/machine-config-operator#1619 right?

@cgwalters
Copy link
Member

I think we should do it but let's get #368 first, doesn't need to happen at the same time.

@elmiko
Copy link
Contributor

elmiko commented Jun 24, 2020

this sounds reasonable to me as well

@runcom
Copy link
Member

runcom commented Jul 2, 2020

Would we agree this is more like a bug/shortcoming we have in MCO? why do we need an enhancement? it sounds like a straightforward fix we can do in the MCO anyway (as we sync the original pools and we can add the userdata creation there as well)

@michaelgugino
Copy link
Contributor Author

@runcom well, it's one of those things that touches multiple areas. The machine-api needs to have the user-data secret, MCO needs to create it. Whether or not this amounts to the level of an 'enhancement' IDK. I filed it in this repo because it's a cross-component issue. I didn't write a full enhancement because that seems unnecessary.

@runcom
Copy link
Member

runcom commented Jul 27, 2020

@michaelgugino
Copy link
Contributor Author

@runcom looks good. Anything cleaning these secrets up? I think it's probably okay to leave them there for the most part.

@runcom
Copy link
Member

runcom commented Jul 28, 2020

@runcom looks good. Anything cleaning these secrets up? I think it's probably okay to leave them there for the most part.

nothing today but we can add something going forward - we don't have anything cleaning unused MCs yet so it should be safe as we're going to rerender the secrets as well in case something changes

@michaelgugino
Copy link
Contributor Author

nothing today but we can add something going forward - we don't have anything cleaning unused MCs yet so it should be safe as we're going to rerender the secrets as well in case something changes

@runcom yeah, I think cleaning up MCs based on 'unused' is tricky. It might be a config I only use every so often for a particular type of workload, so it might be perfectly valid to have a MC that goes unused for an extended period of time.

As far as deleting the user-data, I'm fine with it not being deleted automatically. I think we could potentially set an owner-ref (does that work cross namespace?) on the user-data pointing to the relevant MCP and cleanup will happen automatically (again, not required IMO).

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 30, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelgugino
Copy link
Contributor Author

/reopen

@openshift-ci-robot
Copy link

@michaelgugino: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelgugino
Copy link
Contributor Author

/reopen

@openshift-ci-robot
Copy link

@michaelgugino: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants