Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart generator #4872

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Helm chart generator #4872

wants to merge 2 commits into from

Conversation

geoberle
Copy link
Contributor

@geoberle geoberle commented Oct 9, 2024

What this PR does / why we need it:

Introduce a install helm command to generate a helm chart with some templatization options similar to the install render --template command.

the PR also introduces a way to template the registry overrides option of the operator

required by Azure/ARO-HCP#698

Which issue(s) this PR fixes:

Fixes #ARO-11084

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
this PR refactors the openshift-template generation logic from `install render` and introduces a helm chart generator on top of that.

helm is the preferred way of deploying services for ARO HCP related services.

https://issues.redhat.com/browse/ARO-11084

Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2024
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/cli Indicates the PR includes changes for CLI labels Oct 9, 2024
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geoberle
Once this PR has been reviewed and has the lgtm label, please assign muraee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geoberle geoberle changed the title Helm Helm chart generator Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Indicates the PR includes changes for CLI do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant