Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-31807: [release-4.15] use update only secret-apply for cert rotation logic #1710

Merged
merged 1 commit into from
Apr 9, 2024
Merged

OCPBUGS-31807: [release-4.15] use update only secret-apply for cert rotation logic #1710

merged 1 commit into from
Apr 9, 2024

Conversation

p0lyn0mial
Copy link
Contributor

back port of #1705
not clean, requires reviewing.

@p0lyn0mial
Copy link
Contributor Author

/assign @tkashem @vrutkovs

@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Apr 5, 2024 •
edited
Loading

/hold

until we get signal from CI/nightly and the QE team.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@openshift-ci openshift-ci bot requested review from mfojtik and stlaz April 5, 2024 11:12
@vrutkovs
Copy link
Member

vrutkovs commented Apr 5, 2024

/jira cherrypick OCPBUGS-31384

@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-31384 has been cloned as Jira Issue OCPBUGS-31807. Will retitle bug to link to clone.
/retitle OCPBUGS-31807: [release-4.15] use update only secret-apply for cert rotation logic

In response to this:

/jira cherrypick OCPBUGS-31384

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] use update only secret-apply for cert rotation logic OCPBUGS-31807: [release-4.15] use update only secret-apply for cert rotation logic Apr 5, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 5, 2024
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Jira Issue OCPBUGS-31807, which is invalid:

  • expected dependent Jira Issue OCPBUGS-31384 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

back port of #1705
not clean, requires reviewing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs
vrutkovs approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@tkashem
Copy link
Contributor

tkashem commented Apr 5, 2024

/lgtm

@mfojtik
Copy link
Contributor

mfojtik commented Apr 5, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, p0lyn0mial, tkashem, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@vrutkovs
Copy link
Member

vrutkovs commented Apr 9, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2024
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-31807, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-31384 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31384 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 April 9, 2024 07:24
@p0lyn0mial
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0ebfe3e into openshift:release-4.15 Apr 9, 2024
4 checks passed
@openshift-ci-robot
Copy link

@p0lyn0mial: Jira Issue OCPBUGS-31807: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-31807 has not been moved to the MODIFIED state.

In response to this:

back port of #1705
not clean, requires reviewing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial p0lyn0mial mentioned this pull request Apr 9, 2024
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 9, 2024
Merged
@tkashem tkashem mentioned this pull request Apr 9, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-04-16-070254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@stlaz stlaz Awaiting requested review from stlaz

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@vrutkovs vrutkovs

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@p0lyn0mial @vrutkovs @openshift-ci-robot @tkashem @mfojtik @openshift-merge-robot