Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share logic for getting the in-use MachineConfigs #1783

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

share logic for getting the in-use MachineConfigs #1783

wants to merge 1 commit into from

Conversation

tremes
Copy link

@tremes tremes commented Aug 30, 2024

This is moving the logic from the https://github.com/openshift/oc/blob/master/pkg/cli/admin/prune/renderedmachineconfigs/renderedmachineconfigs.go#L397 so that it can be reused in the Insights Operator.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tremes
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Author

tremes commented Aug 30, 2024

@wking can you please review and help me with some reviewers and approvers suggestion for this new package?

tremes
tremes commented Aug 30, 2024
View reviewed changes
pkg/machineconfig/in_use_machineconfigs.go
)

// GetInUseMachineConfigs filters in-use MachineConfig resources and returns set of their names.
func GetInUseMachineConfigs(ctx context.Context, clientConfig *rest.Config, poolFilter string) (sets.Set[string], error) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally I can pass the client instances (instead of the config). I think it would allow for some testing.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremes @openshift-merge-robot