Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "RFE-2962: configure ovs should use node-ip-hint set by nodeip-configuration service" #3360

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Oct 3, 2022

Reverts #3233

This is a test, we've got a regression in https://issues.redhat.com/browse/OCPBUGS-1906 likely caused by something in this list: https://sippy.dptools.openshift.org/sippy-ng/release/4.12/tags/4.12.0-0.ci-2022-09-29-133725/pull_requests

Workers are upgrading and rebooting fine, but one master attempts it's reboot, then never comes back. No other masters are attempted. Serial console looks ok.

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Oct 3, 2022

/payload 4.12 ci blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

@dgoodwin: trigger 4 job(s) of type blocking for the ci release of OCP 4.12

  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e7e0cac0-4310-11ed-9856-2bbcd6ea1ecd-0

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Oct 3, 2022

In the original PRs presubmits, I think we can see our regression on an optional azure job: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/3233/pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade/1575170114657980416

Looking likely this is the PR that introduced the regression on Azure.

@cgwalters
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2022
@cgwalters
Copy link
Member

cc @flaper87
cc @jcaamano

@jcaamano
Copy link
Contributor

jcaamano commented Oct 3, 2022

cc @tsorya

@jcaamano
Copy link
Contributor

jcaamano commented Oct 3, 2022

In the original PRs presubmits, I think we can see our regression on an optional azure job: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/3233/pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade/1575170114657980416

Looking likely this is the PR that introduced the regression on Azure.

I guess it was masked by the 25% pass rate of that job.

@jcaamano
Copy link
Contributor

jcaamano commented Oct 3, 2022

Reverts #3233

This is a test, we've got a regression in https://issues.redhat.com/browse/OCPBUGS-1906 likely caused by something in this list: https://sippy.dptools.openshift.org/sippy-ng/release/4.12/tags/4.12.0-0.ci-2022-09-29-133725/pull_requests

Workers are upgrading and rebooting fine, but one master attempts it's reboot, then never comes back. No other masters are attempted. Serial console looks ok.

When you say that serial console looks fine, that's for a pre-upgrade boot right? I don't see the console after upgrade I think.

@stbenjam
Copy link
Member

stbenjam commented Oct 3, 2022

The payload testing seems to confirm it https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/aggregator-periodic-ci-opensh[…]from-stable-4.11-e2e-azure-sdn-upgrade/1576901335637299200 finished about an hour sooner and the upgrade completed

The failures there now look related to the kubelet update

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsorya
Copy link
Contributor

tsorya commented Oct 3, 2022

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

@tsorya: The following commands are available to trigger required jobs:

  • /test 4.12-upgrade-from-stable-4.11-images
  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-gcp-op
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • /test bootstrap-unit
  • /test e2e-aws-disruptive
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upgrade-single-node
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure
  • /test e2e-azure-ovn-upgrade
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op-single-node
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-openstack
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 71469ce and 2 for PR HEAD 13d1db9 in total

@tsorya
Copy link
Contributor

tsorya commented Oct 3, 2022

/test e2e-azure-ovn-upgrade

@tsorya
Copy link
Contributor

tsorya commented Oct 3, 2022

/test e2e-azure-upgrade

@stbenjam
Copy link
Member

stbenjam commented Oct 3, 2022

I believe the evidence points strongly to this PR being the source of the breakage. We don't need the additional azure signal, we already got it from the payload command above.

Looking at the history on this PR https://prow.ci.openshift.org/pr-history/?org=openshift&repo=machine-config-operator&pr=3360, and the payload signal I'm confident reverting this is safe.

/override ci/prow/e2e-openstack
/override ci/prow/e2e-aws
/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws, ci/prow/e2e-openstack

In response to this:

I believe the evidence points strongly to this PR being the source of the breakage. We don't need the additional azure signal, we already got it from the payload command above.

Looking at the history on this PR https://prow.ci.openshift.org/pr-history/?org=openshift&repo=machine-config-operator&pr=3360, and the payload signal I'm confident reverting this is safe.

/override ci/prow/e2e-openstack
/override ci/prow/e2e-aws
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 87bde27 into openshift:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants