mcd: remove unnecessary checks and simplify updateSSHKeys

[kikisdeliveryservice]

Minor updates that I wanted to fix/cleanup since my last ssh pr:

1. remove user.name check this is already done in reconcilable() and is unnecessary here
2. use consts for "core" and core's filepath "/home/core/ssh" to make it more consistent and maintainable.

[kikisdeliveryservice]

/test unit

[runcom]

/approve

[runcom]

/retest

[kikisdeliveryservice]

/test e2e-aws

[kikisdeliveryservice]

/retest

[runcom]

/retest

[runcom]

/retest

[runcom]

/retest

[jlebon]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[ashcrow]

pkg/daemon/update.go:224:1: syntax error: unexpected <<, expecting }
pkg/daemon/update.go:227:1: syntax error: unexpected ==, expecting }
pkg/daemon/update.go:231:1: syntax error: unexpected >>, expecting }
pkg/daemon/update.go:240:2: syntax error: non-declaration statement outside function body

Rebase needed

[kikisdeliveryservice]

Had some rebase woes (no actual changes on my end). Should be fine now.

[kikisdeliveryservice]

"\t* aws_route_table_association.worker_routing.4: timeout while waiting for state to become 'success' (timeout: 5m0s)"

/retest

[kikisdeliveryservice]

I'm going to just hold off on retesting since AWS seems to be going through something today.

[kikisdeliveryservice]

/test e2e-aws

[kikisdeliveryservice]

/test e2e-aws

[runcom]

/retest

[runcom]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlebon,kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[runcom]

/retest

[runcom]

/retest

[ashcrow]

/retest

[kikisdeliveryservice]

Seeing intermittent bug #414 in the last e2e-aws run. ☹️
/test e2e-aws

[kikisdeliveryservice]

/test e2e-aws

[runcom]

/retest