pkg/daemon/update.go: check wait err and wrap it #416
Conversation
openshift-ci-robot
added
approved
runcom
force-pushed
the
check-err-wait
branch
from
e199d44
to
5b915e5
Compare
|
aws ❤️ |
Yeah. Looks like resources. |
|
/retest |
1 similar comment
|
/retest |
pkg/daemon/update.go
Outdated
| if err == nil { | ||
| return true, nil | ||
| } | ||
| lastErr = fmt.Errorf("draining failed with: %v", err) |
There was a problem hiding this comment.
How about just doing glog.Infof() for the error message here and leaving lastErr = err? Then if we wrap it later, we can still get back the original error that happened. (Anyway, "failed to drain node (5 tries): draining failed with: ..." is kinda repetitive, no? :))
runcom
force-pushed
the
check-err-wait
branch
from
5b915e5
to
02218d2
Compare
we missed checking it https://github.com/openshift/machine-config-operator/blob/master/pkg/daemon/update.go#L92 Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
check-err-wait
branch
from
02218d2
to
87b6c2d
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
we missed checking it https://github.com/openshift/machine-config-operator/blob/master/pkg/daemon/update.go#L92
also, refactored the condition function a bit to be more future proof (i.e. someone comes and add a
return false, err)Signed-off-by: Antonio Murdaca runcom@linux.com