Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33762: Hardcode resource groups/kinds for now #1773

Merged
merged 2 commits into from
May 22, 2024
Merged

OCPBUGS-33762: Hardcode resource groups/kinds for now #1773

merged 2 commits into from
May 22, 2024

Commits on May 18, 2024

  1. update status: minor code cleanups

    @petr-muller
    petr-muller committed May 18, 2024
    Configuration menu
    Copy the full SHA
    27e9057 View commit details
    Browse the repository at this point in the history

  2. OCPBUGS-33762: Hardcode resource groups/kinds for now 

    Previous code used `GroupVersionKind` method on actual resources to determine group/kind strings for them, but client-go unfortunately drops `TypeMeta` on resources processed by typed client (kubernetes/client-go#1328, kubernetes/client-go#541). Fortunately we know what types we build insights for, so we can use appropriate strings from client code for groups and hardcode kinds ourselves.
    @petr-muller
    petr-muller committed May 18, 2024
    Configuration menu
    Copy the full SHA
    fad39d2 View commit details
    Browse the repository at this point in the history