consolidate small prs #4737
Merged
consolidate small prs #4737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sosiouxme
commented
Jul 11, 2017
•
sosiouxme
commented
- downstream dockerfile fixes downstream dockerfile fixes #4715
- fix execute_module params openshift_checks: fix execute_module params #4729
- improve ssh ControlPath ansible.cfg: improve ssh ControlPath #4705
- Add overlay to supported Docker storage drivers Add overlay to supported Docker storage drivers #4722
- Only store failures that were not ignored. Only store failures that were not ignored. #4713
- add check for scheduled pods add check for scheduled pods #4728
sync the parallel change from Dockerfile into Dockerfile.rhel7
https://bugzilla.redhat.com/show_bug.cgi?id=1465724 Use the provided ansible.cfg and hack needed python system libs into SCL
SUMMARY and DESCRIPTION were coming from python image build, might be confusing to someone inspecting this image.
Fix where execute_module was being passed task_vars in place of tmp param. Most modules don't seem to use either and so this doesn't fail; but under some conditions (perhaps different per version of ansible?) it tried to treat the dict as a string and came back with a python stack trace.
AWS hosts and user names frequently make the default Ansible ControlPath too long. This prevents ssh persistent connections, significantly impacting runtime. More detail: ansible/ansible#11536 This config change shortens the ControlPath to make this less likely. It would be better to change it to the %C hash, as extremely long hostnames or usernames could still encounter this problem, but that is not yet available with RHEL's openssh. This at least improves the situation.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1467809 As a next step, we can refine under which conditions the overlay driver is supported.
In the past, health checks were implemented with ignore_errors: True in the playbook level, requiring us to store all failures, ignored or not, so that we could report on all failed checks. Now checks are run from a single action plugin entry point, without ignoring errors (all errors are aggregated via the action plugin). Since the integration of the openshift_health_checker role with the install playbook, failure summaries are part of the output of a lot more calls to ansible-playbook. We shall report only failures that caused the execution to stop, as ignored failures in the summary only serve to confuse users.
|
aos-ci-test |
juanvallejo
approved these changes
Jul 11, 2017
|
I'm going to optimistically [merge][severity: bug] and hope that aos-ci-test comes back happy. |
|
at least the aos-ci-test came back happy (if very slow) [merge][severity: blocker] |
|
Evaluated for openshift ansible merge up to 1c213b5 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/691/) (Base Commit: 0d0c6d1) (PR Branch Commit: 1c213b5) (Extended Tests: blocker, bug) |
This was referenced Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.