Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS-368: [CLONED] Deploying an OCP cluster manually without Assisted Installer (regardless of use case) #39205

Merged
merged 1 commit into from
Dec 1, 2021
Merged

TELCODOCS-368: [CLONED] Deploying an OCP cluster manually without Assisted Installer (regardless of use case) #39205

merged 1 commit into from
Dec 1, 2021

Conversation

aireilly
Copy link
Contributor

@aireilly aireilly commented Nov 24, 2021 •
edited by openshift-ci bot
Loading

This PR is a clone of #38068

Adds modules for generating the ISO manually and monitoring the installation manually. It also renames the doc back to Single Node OpenShift (SNO), which was originally removed because it was not present in a spreadsheet that peer reviewers used to verify names.

Fixes: TELCODOCS-368

See https://issues.redhat.com/browse/TELCODOCS-368 for additional details.

Preview URL: https://deploy-preview-39205--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_sno/install-sno-preparing-to-install-sno.html

For release(s): 4.9, 4.10
Signed-off-by: John Wilkins jowilkin@redhat.com

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2021
@netlify
Copy link

netlify bot commented Nov 24, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 10f31b4

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61a6266b461ca60007828e41

😎 Browse the preview: https://deploy-preview-39205--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_sno/install-sno-installing-sno

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021
@aireilly aireilly force-pushed the TELCODOCS-368_JohnWilkins branch 4 times, most recently from 01a6bf2 to 04ce5bc Compare November 24, 2021 13:23
@aireilly aireilly mentioned this pull request Nov 24, 2021
Closed
@aireilly aireilly changed the title TELCODOCS-368: Deploying an OCP cluster manually without Assisted Installer (regardless of use case) TELCODOCS-368: [CLONED] Deploying an OCP cluster manually without Assisted Installer (regardless of use case) Nov 24, 2021
eranco74
eranco74 reviewed Nov 24, 2021
View reviewed changes
Copy link

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

modules/install-sno-generate-the-discovery-iso-manually.adoc Outdated Show resolved Hide resolved
@pamoedom
Copy link

pamoedom commented Nov 25, 2021 •
edited
Loading

@aireilly, the changes looks good to me, but I think we'll need to consider/wait for ongoing [SUPPORTEX-6622] that could affect the final version of this documentation. I have commented there the situation and waiting for feedback, I'll keep you posted if any progress in order to move forward, thanks for your understanding.

Best Regards.

@pamoedom
Copy link

@aireilly, as discussed, we are moving forward with this PR, we'll track the iPXE method on a separated issue if needed. Thanks.

@pamoedom
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2021
@aireilly aireilly force-pushed the TELCODOCS-368_JohnWilkins branch 3 times, most recently from b5b0735 to 52b6eed Compare November 25, 2021 17:30
@pamoedom
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2021
ctauchen
ctauchen reviewed Nov 26, 2021
View reviewed changes
Copy link
Contributor

@ctauchen ctauchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aireilly Here's a few fixes for you to consider.

Some general things:

  • We need confirmation that "Single Node OpenShift" is good to use as an official RH solution name. It appears that this term was disallowed when these docs were first written. If it's being restored, we need to know that this is approved.

installing/installing_sno/install-sno-installing-sno.adoc Outdated Show resolved Hide resolved
modules/install-sno-generate-the-discovery-iso-manually.adoc Outdated Show resolved Hide resolved
installing/installing_sno/install-sno-installing-sno.adoc Outdated Show resolved Hide resolved
modules/install-sno-monitoring-the-installation-with-the-assisted-installer.adoc Outdated Show resolved Hide resolved
modules/install-sno-monitoring-the-installation-with-the-assisted-installer.adoc Outdated Show resolved Hide resolved
modules/install-sno-generate-the-discovery-iso-manually.adoc Outdated Show resolved Hide resolved
installing/installing_sno/install-sno-installing-sno.adoc Outdated Show resolved Hide resolved
modules/install-sno-generate-the-discovery-iso-manually.adoc Outdated Show resolved Hide resolved
modules/install-sno-generate-the-discovery-iso-manually.adoc Outdated Show resolved Hide resolved
modules/install-sno-generate-the-discovery-iso-manually.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2021
@aireilly aireilly force-pushed the TELCODOCS-368_JohnWilkins branch 2 times, most recently from 0d8682e to 53a4fe6 Compare November 26, 2021 16:05
@aireilly aireilly force-pushed the TELCODOCS-368_JohnWilkins branch 5 times, most recently from 096c773 to 6d2a1cd Compare November 26, 2021 16:48
@pamoedom
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
ctauchen
ctauchen reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aireilly Nearly there! A few suggestions in the comments.

installing/installing_sno/install-sno-preparing-to-install-sno.adoc Outdated Show resolved Hide resolved
modules/install-sno-about-installing-single-node-openshift.adoc Outdated Show resolved Hide resolved
modules/install-sno-generating-the-discovery-iso-manually.adoc Outdated Show resolved Hide resolved
modules/install-sno-generating-the-discovery-iso-with-the-assisted-installer.adoc Outdated Show resolved Hide resolved
modules/install-sno-generating-the-discovery-iso-with-the-assisted-installer.adoc Outdated Show resolved Hide resolved
modules/install-sno-monitoring-the-installation-manually.adoc Outdated Show resolved Hide resolved
modules/install-sno-monitoring-the-installation-with-the-assisted-installer.adoc Outdated Show resolved Hide resolved
modules/install-sno-generating-the-discovery-iso-manually.adoc Outdated Show resolved Hide resolved
installing/installing_sno/install-sno-installing-sno.adoc Outdated Show resolved Hide resolved
@ctauchen ctauchen added this to the Next Release milestone Nov 30, 2021
@ctauchen ctauchen added branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR labels Nov 30, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2021

New changes are detected. LGTM label has been removed.

@johnwilkins @aireilly
TELCODOCS-368: TELCODOCS-368: Adds a manual procedure for creating th…
10f31b4 
…e ISO and a manual procedure for monitoring install..
@ctauchen
Copy link
Contributor

ctauchen commented Dec 1, 2021

lgtm

@ctauchen ctauchen merged commit c312ffd into openshift:main Dec 1, 2021
@ctauchen
Copy link
Contributor

ctauchen commented Dec 1, 2021

/cherrypick enterprise-4.9

@ctauchen
Copy link
Contributor

ctauchen commented Dec 1, 2021

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 1, 2021
Merged
@openshift-cherrypick-robot
Copy link

@ctauchen: new pull request created: #39429

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 1, 2021
Merged
@openshift-cherrypick-robot
Copy link

@ctauchen: new pull request created: #39430

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aireilly aireilly deleted the TELCODOCS-368_JohnWilkins branch March 10, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranco74 eranco74 eranco74 left review comments

@ctauchen ctauchen ctauchen left review comments

Assignees

@pamoedom pamoedom

Labels
branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
6 participants
@aireilly @pamoedom @ctauchen @openshift-cherrypick-robot @eranco74 @johnwilkins