Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1732364: Add jaeger permissions to create ES index templates #1699

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Bug 1732364: Add jaeger permissions to create ES index templates #1699

merged 1 commit into from
Aug 7, 2019

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Jul 19, 2019 •
edited
Loading

Jaeger now creates index templates at startup. Before it was creating an index with supplied mapping which could result in an index with incorrect mapping.

https://bugzilla.redhat.com/show_bug.cgi?id=1732364

Related Jaeger PR jaegertracing/jaeger#1627

@pavolloffay
Add jaeger permissions to create ES templates
42dea9d 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 19, 2019
@openshift-ci-robot
Copy link

Hi @pavolloffay. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2019
@pavolloffay
Copy link
Member Author

Which branch should this go in? 4.1 or master?

We do not specify ES image in Jaeger operator and rely on what ES operator provides by default. Therefore I think this should go inside 4.1 cc @objectiser?

@objectiser
Copy link

Yes we would need this change in both master and release-4.1 branches.

@pavolloffay
Copy link
Member Author

@jcantrill @richm should I open a separate PR or do you just cherry-pick commit?

@pavolloffay pavolloffay mentioned this pull request Jul 19, 2019
Merged
@pavolloffay
Copy link
Member Author

I have submitted #1700 to backport to 4.1 branch

jcantrill
jcantrill approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2019
@richm
Copy link
Contributor

richm commented Jul 19, 2019

/retest

@pavolloffay pavolloffay changed the title Add jaeger permissions to create ES index templates Bug 1732364: Add jaeger permissions to create ES index templates Jul 23, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 23, 2019
@openshift-ci-robot
Copy link

@pavolloffay: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1732364: Add jaeger permissions to create ES index templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pavolloffay
Copy link
Member Author

@jcantrill @richm could this ber merged?

richm
richm approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@richm
Copy link
Contributor

richm commented Jul 25, 2019

/test full-integ-aws

@richm
Copy link
Contributor

richm commented Jul 26, 2019

/test full-integ-aws

@pavolloffay
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 26, 2019
@openshift-ci-robot
Copy link

@pavolloffay: This pull request references an invalid Bugzilla bug:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pavolloffay
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@pavolloffay: This pull request references an invalid Bugzilla bug:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pavolloffay
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@pavolloffay: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 26, 2019
@richm
Copy link
Contributor

richm commented Jul 26, 2019

/retest

1 similar comment
@pavolloffay
Copy link
Member Author

/retest

@richm
Copy link
Contributor

richm commented Jul 30, 2019

/test full-integ-aws

1 similar comment
@richm
Copy link
Contributor

richm commented Jul 30, 2019

/test full-integ-aws

@richm
Copy link
Contributor

richm commented Jul 30, 2019

rsyslog flake?
/test full-integ-aws

@richm
Copy link
Contributor

richm commented Jul 31, 2019

/test full-integ-aws

2 similar comments
@richm
Copy link
Contributor

richm commented Aug 1, 2019

/test full-integ-aws

@richm
Copy link
Contributor

richm commented Aug 1, 2019

/test full-integ-aws

@pavolloffay
Copy link
Member Author

@richm @bparees can this be merged?

@richm richm added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, pavolloffay, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3cea28a into openshift:master Aug 7, 2019
@openshift-ci-robot
Copy link

@pavolloffay: The Bugzilla bug is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 1732364: Add jaeger permissions to create ES index templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richm richm richm approved these changes

@jcantrill jcantrill jcantrill approved these changes

@bparees bparees Awaiting requested review from bparees

@nhosoi nhosoi Awaiting requested review from nhosoi

Assignees

@richm richm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/elasticsearch lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release/4.2 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pavolloffay @openshift-ci-robot @objectiser @richm @jcantrill @openshift-merge-robot