Windows Client Fails to Compile

[stevekuznetsov]

As seen in the devenv_ami jobs

+ vagrant ssh -c 'cd /data/src/github.com/openshift/origin && make build-cross'
rm -rf _output
hack/build-cross.sh
++ Building go targets for linux/amd64: cmd/openshift cmd/oc
++ Building go targets for darwin/amd64: cmd/openshift cmd/oc
++ Building go targets for windows/amd64: cmd/openshift cmd/oc
# github.com/openshift/origin/vendor/github.com/docker/docker/pkg/term/windows
vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:186: cannot use keyEvent.VirtualKeyCode (type winterm.WORD) as type uint16 in argument to formatVirtualKey
vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:186: cannot use keyEvent.ControlKeyState (type winterm.DWORD) as type uint32 in argument to formatVirtualKey
vendor/github.com/docker/docker/pkg/term/windows/ansi_reader.go:189: cannot use keyEvent.ControlKeyState (type winterm.DWORD) as type uint32 in argument to getControlKeys
# github.com/openshift/origin/vendor/github.com/Microsoft/go-winio
vendor/github.com/Microsoft/go-winio/zsyscall_windows.go:15: undefined: "github.com/openshift/origin/vendor/golang.org/x/sys/windows".NewLazySystemDLL
vendor/github.com/Microsoft/go-winio/zsyscall_windows.go:16: undefined: "github.com/openshift/origin/vendor/golang.org/x/sys/windows".NewLazySystemDLL
vendor/github.com/Microsoft/go-winio/zsyscall_windows.go:17: undefined: "github.com/openshift/origin/vendor/golang.org/x/sys/windows".NewLazySystemDLL
[ERROR] PID 2551: hack/common.sh:257: `local -a binaries=("$@")` exited with status 1.
[INFO] 		Stack Trace: 
[INFO] 		  1: hack/common.sh:257: `local -a binaries=("$@")`
[INFO] 		  2: hack/build-cross.sh:24: os::build::build_binaries
[INFO]   Exiting with code 1.
make: *** [build-cross] Error 1
Build step 'Execute shell' marked build as failure

@smarterclayton @csrwng

[stevekuznetsov]

@soltysh could your Godeps changes have touched this?

[stevekuznetsov]

/cc @ncdc re: windows terminal dependency

[pweil-]

@jim-minter it looks like you bumped the windows dep back in November, do you have any insight on debugging this one?

[jim-minter]

@pweil- this looks highly likely to be related to my change. Some other things needed to be bumped in conjunction. Let me prepare a PR.

[jim-minter]

@smarterclayton @pweil- please see #12078 , once it tests please could one of you merge it?

[jim-minter]

@stevekuznetsov is it expected/intentional that this wasn't picked up by standard CI merge testing? Might it be possible to include the cross-build there?

[stevekuznetsov]

Yeah, we got rid of the full cross-compile since it was taking about ten calendar years to finish with Go 1.6. We are probably going to add such a job.

[soltysh]

I've seen Jim's PR, but since my checker wasn't in place yet it probably wasn't caught. I'll be looking into this once again tomorrow to verify the godeps are restored and working as expected.

[jim-minter]

Thanks @soltysh