cross-build (Windows) fix #12078
Merged
cross-build (Windows) fix #12078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we still need ansi_reader.go with the WORD -> uint16 change (it came from 734a79b). Right @smarterclayton ? |
|
Yes, I believe that's still necessary (I don't remember when docker bumped
or if they had)
On Nov 30, 2016, at 2:22 PM, OpenShift Bot <notifications@github.com> wrote:
continuous-integration/openshift-jenkins/test Running (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11827/) (Base
Commit: b32bbcf
<b32bbcf>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12078 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pyZIpOVuqJO09bTzPX2Nb7oroXOoks5rDczagaJpZM4LAkAp>
.
|
|
Chatting with @jim-minter on irc; he's bumping golang.org/x/sys and thinks the WORD change is no longer necessary. We'll see... |
jim-minter
force-pushed
the
windows-fix
branch
from
a738894
to
bedff43
Compare
|
[test] |
|
[test] |
|
Evaluated for origin test up to bedff43 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11849/) (Base Commit: 46f4630) |
|
Merging as is, will look into godeps when this is in. [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11849/) (Base Commit: 46f4630) (Image: devenv-rhel7_5454) |
|
Evaluated for origin merge up to bedff43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12077