Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move oc deploy in oc rollout #9298

Closed
0xmichalis opened this issue Jun 13, 2016 · 2 comments
Closed

Move oc deploy in oc rollout #9298

0xmichalis opened this issue Jun 13, 2016 · 2 comments

Comments

@0xmichalis
Copy link
Contributor

#8927 adds support for rollout, the command used by Kubernetes to manage deployments. We need to move bits from oc deploy in rollout subcommands.

oc deploy --latest to oc rollout again
oc deploy --latest (as it should work) to oc rollout latest

If anybody can come up with more appropriate names, please do so.

Before we add those, I am going to create an /instantiate endpoint that can be used by both oc deploy --latest and the rollout subcommands (and every other client for that matter). Not sure if there is any benefit in waiting for this to be added upstream, it seems that pros outweight cons at this point for having it.

I still need to think about the rest. Both oc deploy --cancel and oc deploy --retry are OpenShift-specific at this point and we still need to add perm-failed (kubernetes/kubernetes#14519) upstream and then get back to those. --enable-triggers is OS-specific atm but will work for both too.

@fabianofranz @ironcladlou @mfojtik @smarterclayton

@0xmichalis
Copy link
Contributor Author

Last pieces left here:

@mfojtik
Copy link
Contributor

mfojtik commented Dec 7, 2016

@Kargakis i will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants